Allow dask>2024.7.1 #326
Open
Allow dask>2024.7.1 #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sadielbartholomew
approved these changes
Mar 4, 2025
There was a problem hiding this comment.
(Reviewing in tandem with the cf-python PR, so will submit my review for that in a moment.) I am happy with this branch (i.e. on the cfdm side), with a few minor comments on the code changes. And functionally, all is good with sufficient new testing - works here and working downstream with the cf-python branch too, hence approving on PR NCAS-CMS/cf-python#849 also.
As discussed this morning in the video call, I am not testing on performance since I am assuming this will not significantly affect the performance of either cfdm or cf-python. So as long as you are happy to assume that, too (else I can review this in that respect, too).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #321