Skip to content
This repository was archived by the owner on Jul 24, 2023. It is now read-only.

Kta 62 automated tests #15

Merged
merged 40 commits into from
Oct 21, 2022
Merged

Kta 62 automated tests #15

merged 40 commits into from
Oct 21, 2022

Conversation

sandoche
Copy link
Contributor

@sandoche sandoche commented Oct 20, 2022

@ryancwalsh you don't need to check this PR yet, I created it to be able to test the github actions.

@sandoche
Copy link
Contributor Author

@ryancwalsh I need the access to create env variables in github, I don't see the tab, I don't have the permissions I guess

@sandoche sandoche requested a review from ryancwalsh October 20, 2022 13:35
@sandoche
Copy link
Contributor Author

@ryancwalsh PR ready to be tested, no hurries and please try to run it locally so we can make sure the doc is correct. Note that I replaced .env.development.local to .env (because the dotenv was not recognizing it).

Copy link
Contributor

@ryancwalsh ryancwalsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks very good! And 3 of the tests pass.

Only this one failed. Do all tests pass for you right now?

image

@sandoche
Copy link
Contributor Author

sandoche commented Oct 21, 2022

@ryancwalsh all the tests passes for me and also you can see that they pass in github: https://github.com/NEARFoundation/near-kyc-onfido/actions

I noticed once that it failed randomly locally, my guess is that the onfido backend got slowdown maybe because of too many requests at the same time.

Maybe try with 1 worker running the following command:

yarn test -- --workers=1

@sandoche sandoche merged commit 8227597 into develop Oct 21, 2022
@sandoche sandoche deleted the KTA-62-automated-tests branch October 21, 2022 08:06
@ryancwalsh
Copy link
Contributor

On develop running yarn test -- --workers=1 I still get that 1 failure, and the others pass.

@ryancwalsh
Copy link
Contributor

But with yarn test:headed all 4 passed!

@sandoche
Copy link
Contributor Author

Strange, but good it passed! Maybe it's linked to the M1 architecture, who knows :/

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants