Skip to content
This repository was archived by the owner on Jul 24, 2023. It is now read-only.

Kta 97 max retries limit #34

Merged
merged 17 commits into from
Nov 30, 2022
Merged

Kta 97 max retries limit #34

merged 17 commits into from
Nov 30, 2022

Conversation

sandoche
Copy link
Contributor

@sandoche sandoche commented Nov 30, 2022

What I implemented:

  • The retry button disappears at the 3rd trial
  • You see a message at the 3rd trial asking to restart
  • The API endpoint to create a check is protected
  • The form page contains the same error message

Third trial message

failed_third_time

Message in the form page

homepage_after_failing

Copy link
Member

@PierreLeGuen PierreLeGuen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So it means that if someone empties his cookies, he can spam requests?

@sandoche
Copy link
Contributor Author

@PierreLeGuen yes, you can, but you need to be willing to scan your documents and take as many selfies as needed. It's just a small protection.

Copy link
Member

@PierreLeGuen PierreLeGuen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sandoche sandoche merged commit 6f4612a into develop Nov 30, 2022
@sandoche sandoche deleted the KTA-97-max-retries-limit branch November 30, 2022 16:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants