This repository was archived by the owner on Jul 24, 2023. It is now read-only.
Kta 100 bug country missing #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ryancwalsh @PierreLeGuen I'll merge this since it passes the tests and fix a critical bug |
PierreLeGuen
reviewed
Dec 1, 2022
| @@ -50,11 +51,14 @@ const onfido = getOnfido(); | |||
| export default async function handler(req: NextApiRequest, res: NextApiResponse<ApplicantTokenPair | unknown>) { | |||
| try { | |||
| const ipAddress = req.headers['x-real-ip'] ?? req.connection.remoteAddress; | |||
| const countryOfResidence = getCountryCodeFromTimezone(req.body.timezone); | |||
| console.log('countryOfResidence', countryOfResidence); | |||
There was a problem hiding this comment.
Are console logs printed in prod? If yes, console logs should be removed or disabled in prod.
There was a problem hiding this comment.
This code is run by the backend so it's a console log displayed in the backend for logging purpose.
There was a problem hiding this comment.
It's not printed to the browser.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.