-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(module:segmented): redesign the segmented component #8753
feat(module:segmented): redesign the segmented component #8753
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8753 +/- ##
==========================================
+ Coverage 91.93% 91.94% +0.01%
==========================================
Files 536 538 +2
Lines 18455 18491 +36
Branches 2816 2821 +5
==========================================
+ Hits 16967 17002 +35
Misses 1183 1183
- Partials 305 306 +1 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
b7e3b63
to
9be825b
Compare
44cd190
to
4b9dc6f
Compare
4b9dc6f
to
5b41686
Compare
92a673a
to
334ed50
Compare
334ed50
to
1a090e8
Compare
this.cdr.detectChanges(); | ||
}); | ||
|
||
effect(() => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Select the first item by default if not set
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
option.value
[nz-segmented-item]
组件,提供直接的自定义渲染功能Does this PR introduce a breaking change?
option.value
nzLabelTemplate
input,将其移除EventEmitter<number>
修改为EventEmitter<number | string>
Other information