Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: change owner to simplejason for reassignment #8854

Merged
merged 2 commits into from
Nov 8, 2024

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Nov 1, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe: change owner

What is the current behavior?

Since I have not been working with Angular for years, maybe it is better to give the ownership to other maintainers :) Please reassign modules I used to own @simplejason.

Go NG-ZORRO!

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@wzhudev wzhudev requested a review from simplejason November 1, 2024 11:17
Copy link

zorro-bot bot commented Nov 1, 2024

This preview will be available after the AzureCI is passed.

Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.94%. Comparing base (29827df) to head (a8ddd1a).
Report is 12 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8854   +/-   ##
=======================================
  Coverage   91.93%   91.94%           
=======================================
  Files         537      537           
  Lines       18456    18457    +1     
  Branches     2816     2816           
=======================================
+ Hits        16968    16970    +2     
  Misses       1184     1184           
+ Partials      304      303    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@simplejason simplejason merged commit 177a9b4 into NG-ZORRO:master Nov 8, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants