-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(module:checkbox): redesign the checkbox group component #8932
feat(module:checkbox): redesign the checkbox group component #8932
Conversation
f6a04fc
to
2dcbdd4
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8932 +/- ##
=======================================
Coverage 91.91% 91.91%
=======================================
Files 554 555 +1
Lines 19682 19697 +15
Branches 2936 2940 +4
=======================================
+ Hits 18091 18105 +14
- Misses 1265 1267 +2
+ Partials 326 325 -1 ☔ View full report in Codecov by Sentry. |
e6e7a6d
to
bff57eb
Compare
9b78ba2
to
e124bf8
Compare
e124bf8
to
a6c0a0c
Compare
a6c0a0c
to
8ada51c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #4883
<nz-checkbox-group>
的ngModel
的类型为NzCheckBoxOptionInterface[]
,与 antd 不一致<nz-checkbox-group>
无法像 antd 那样自定义布局,需要借助<nz-checkbox-wrapper>
组件实现自定义布局,但<nz-checkbox-wrapper>
又不是一个控件组件,用途不大。实际上<nz-checkbox-wrapper>
应该被实现为<nz-checkbox-group>
。What is the new behavior?
<nz-checkbox-group>
的ngModel
的类型修正为NzCheckBoxOptionInterface['value'][]
<nz-checkbox-group>
支持自定义布局<nz-checkbox-group>
新增[nzOptions]
<nz-checkbox-group>
新增[nzName]
[nz-checkbox]
新增[nzName]
<nz-checkbox-wrapper>
NzCheckBoxOptionInterface
,使用NzCheckBoxOption
替代Does this PR introduce a breaking change?
<nz-checkbox-group>
的ngModel
的类型修改为NzCheckBoxOptionInterface['value'][]
NzCheckBoxOptionInterface['checked']
Other information