DKMS build 4.1.1 failed on centos 8

[ruben-herold]

bash-4.4# cat /etc/redhat-release
CentOS Linux release 8.2.2004 (Core)
bash-4.4#

jool 4.1.1:

DKMS make.log for jool-4.1.1 for kernel 4.18.0-211.el8.x86_64 (x86_64)
Mon Jul 13 23:23:25 CEST 2020
make: Entering directory '/usr/src/kernels/4.18.0-211.el8.x86_64'
CC [M] /var/lib/dkms/jool/4.1.1/build/src/mod/common/rfc7915/4to6.o
CC [M] /var/lib/dkms/jool/4.1.1/build/src/mod/common/rfc7915/6to4.o
/var/lib/dkms/jool/4.1.1/build/src/mod/common/rfc7915/6to4.c: In function ‘select_any_saddr’:
/var/lib/dkms/jool/4.1.1/build/src/mod/common/rfc7915/6to4.c:261:3: error: implicit declaration of function ‘for_primary_ifa’ [-Werror=implicit-function-declaration]
for_primary_ifa(in_dev) {
^~~~~~~~~~~~~~~
/var/lib/dkms/jool/4.1.1/build/src/mod/common/rfc7915/6to4.c:261:26: error: expected ‘;’ before ‘{’ token
for_primary_ifa(in_dev) {
^~
;
/var/lib/dkms/jool/4.1.1/build/src/mod/common/rfc7915/6to4.c:274:1: warning: label ‘success’ defined but not used [-Wunused-label]
success:
^~~~~~~
cc1: some warnings being treated as errors
make[1]: *** [scripts/Makefile.build:315: /var/lib/dkms/jool/4.1.1/build/src/mod/common/rfc7915/6to4.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:1545: module/var/lib/dkms/jool/4.1.1/build/src/mod/common] Error 2

[ydahhrk]

Huh?! Did they seriously change the API in some sort of minor release? It compiles fine in my CentOS 8 VM (though it's not updated to the latest version).

Won't be able to test until tomorrow, but try changing

#if LINUX_VERSION_AT_LEAST(5, 3, 0, 9999, 0)

into

#if LINUX_VERSION_AT_LEAST(5, 3, 0, 8, 0)

in the select_any_saddr() function from the src/mod/common/rfc7915/6to4.c file. Note, there are two of them.

[ruben-herold]

Same error:

DKMS make.log for jool-4.1.1 for kernel 4.18.0-211.el8.x86_64 (x86_64)
Tue Jul 14 10:19:34 CEST 2020
make: Entering directory '/usr/src/kernels/4.18.0-211.el8.x86_64'
CC [M] /var/lib/dkms/jool/4.1.1/build/src/mod/common/rfc7915/4to6.o
CC [M] /var/lib/dkms/jool/4.1.1/build/src/mod/common/rfc7915/6to4.o
CC [M] /var/lib/dkms/jool/4.1.1/build/src/mod/common/rfc7915/common.o
CC [M] /var/lib/dkms/jool/4.1.1/build/src/mod/common/rfc7915/core.o
CC [M] /var/lib/dkms/jool/4.1.1/build/src/mod/common/address_xlat.o
CC [M] /var/lib/dkms/jool/4.1.1/build/src/mod/common/dev.o
/var/lib/dkms/jool/4.1.1/build/src/mod/common/dev.c: In function ‘foreach_ifa’:
/var/lib/dkms/jool/4.1.1/build/src/mod/common/dev.c:30:3: error: implicit declaration of function ‘for_primary_ifa’; did you mean ‘foreach_ifa’? [-Werror=implicit-function-declaration]
for_primary_ifa(in_dev) {
^~~~~~~~~~~~~~~
foreach_ifa
/var/lib/dkms/jool/4.1.1/build/src/mod/common/dev.c:30:26: error: expected ‘;’ before ‘{’ token
for_primary_ifa(in_dev) {
^~
;
/var/lib/dkms/jool/4.1.1/build/src/mod/common/dev.c:38:1: warning: label ‘end’ defined but not used [-Wunused-label]
end:
^~~
cc1: some warnings being treated as errors
make[1]: *** [scripts/Makefile.build:315: /var/lib/dkms/jool/4.1.1/build/src/mod/common/dev.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:1545: module/var/lib/dkms/jool/4.1.1/build/src/mod/common] Error 2
make: Leaving directory '/usr/src/kernels/4.18.0-211.el8.x86_64'

[ydahhrk]

Ok, ran the test suite on it.

Please close the issue if the problem was solved.

[ruben-herold]

Yes it runs fine with the current git.
Thx for the fast response!