Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infeasible configuration on the document #388

Closed
yuuzi41 opened this issue Oct 4, 2022 · 1 comment
Closed

Infeasible configuration on the document #388

yuuzi41 opened this issue Oct 4, 2022 · 1 comment
Labels
Milestone

Comments

@yuuzi41
Copy link
Contributor

yuuzi41 commented Oct 4, 2022

"Atomic Configuration" ( https://nicmx.github.io/Jool/en/config-atomic.html#nat64 ) shows the example configuration for NAT64, but actually it is not feasible.

This configuration contains a BIB for TCP port 80 as following:

  {
  	"protocol": "TCP",
  	"ipv6 address": "2001:db8::1#80",
  	"ipv4 address": "192.0.2.1#80"
  }, {

but the configuration of pool4 contains an entry for TCP having only 61001-62000 port ranges.

  {
  	"comment": "mark, port range and max-iterations are optional.",
  	"protocol": "TCP",
  	"prefix": "192.0.2.1/32"
  }, {

Jool requires that incoming IPv4 packets must match any pool4 entries. https://github.com/NICMx/Jool/blob/master/src/mod/common/steps/filtering_and_updating.c#L526

Therefore the BIB mentioned above is not workable and that's why I think the configuration is not feasible.

ydahhrk added a commit that referenced this issue Oct 5, 2022
Should prevent #388 from ever happening again.
@ydahhrk
Copy link
Member

ydahhrk commented Oct 5, 2022

Thank you very much.

I uploaded an additional commit to validate this properly during the atomic configuration handler. I'm going to wait for a release because there might be a reason why this validation didn't exist before, but nothing comes to mind right now.

@ydahhrk ydahhrk closed this as completed Oct 5, 2022
@ydahhrk ydahhrk added this to the 4.1.9 milestone Jan 25, 2023
@ydahhrk ydahhrk added the Bug label Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants