Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python chapter #8

Merged
merged 12 commits into from
Mar 12, 2020
Merged

Python chapter #8

merged 12 commits into from
Mar 12, 2020

Conversation

sverhoeven
Copy link
Member

@sverhoeven sverhoeven commented Mar 9, 2020 •
edited
Loading

Adds

  • Python hello world examples
  • Simple NH calc with Flask
  • Submit/Poll/Result NH calc with Flask and Celery
  • Connexion based OpenAPI web service

@sverhoeven sverhoeven self-assigned this Mar 9, 2020
@sverhoeven sverhoeven removed their assignment Mar 9, 2020
@sverhoeven sverhoeven marked this pull request as ready for review March 9, 2020 15:05
@sverhoeven sverhoeven requested a review from fdiblen March 9, 2020 15:09
fdiblen
fdiblen reviewed Mar 11, 2020
View reviewed changes
fdiblen
fdiblen reviewed Mar 11, 2020
View reviewed changes
fdiblen
fdiblen reviewed Mar 11, 2020
View reviewed changes
fdiblen
fdiblen reviewed Mar 11, 2020
View reviewed changes
fdiblen
fdiblen reviewed Mar 11, 2020
View reviewed changes
fdiblen
fdiblen reviewed Mar 11, 2020
View reviewed changes
fdiblen
fdiblen reviewed Mar 11, 2020
View reviewed changes
Copy link
Collaborator

@fdiblen fdiblen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!
I added few comments.

@fdiblen fdiblen merged commit 86ceb95 into master Mar 12, 2020
@fdiblen fdiblen deleted the python branch March 12, 2020 12:57
@sverhoeven
Copy link
Member Author

Grr, you merged to soon, I was still moving the pip installs, commited those changes to master directly.

@fdiblen fdiblen restored the python branch March 12, 2020 13:31
@fdiblen
Copy link
Collaborator

fdiblen commented Mar 12, 2020

Grr, you merged to soon, I was still moving the pip installs, commited those changes to master directly.

I restored the branch. Give me a sign when you are done.

@sverhoeven
Copy link
Member Author

It is OK for me, I am moving on to #4

@sverhoeven sverhoeven deleted the python branch March 12, 2020 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fdiblen fdiblen fdiblen left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sverhoeven @fdiblen