-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Grib2 writer for oceanicepost #99
Conversation
Sounds good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor comments before we can merge.
@aerorahul I resolved the suggestions. |
@AminIlia-NOAA |
@aerorahul added netcdf flag with default false. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use netcdf
(we don't have to be limited to 2-3 character names) to be more descriptive.
change name to netcdf Co-authored-by: Rahul Mahajan <aerorahul@users.noreply.github.com>
change flag name to netcdf Co-authored-by: Rahul Mahajan <aerorahul@users.noreply.github.com>
change flag name to netcdf Co-authored-by: Rahul Mahajan <aerorahul@users.noreply.github.com>
change flag name to netcdf Co-authored-by: Rahul Mahajan <aerorahul@users.noreply.github.com>
change flag name to netcdf Co-authored-by: Rahul Mahajan <aerorahul@users.noreply.github.com>
change flag name to netcdf Co-authored-by: Rahul Mahajan <aerorahul@users.noreply.github.com>
change flag name to netcdf Co-authored-by: Rahul Mahajan <aerorahul@users.noreply.github.com>
change flag name to netcdf Co-authored-by: Rahul Mahajan <aerorahul@users.noreply.github.com>
change flag name to netcdf Co-authored-by: Rahul Mahajan <aerorahul@users.noreply.github.com>
@aerorahul ncf was ok as fortran compiler mixed netcdf flag with necdf lib module. I changed the name of flag to netcdff. |
May I suggest, in that case, to replace |
@aerorahul I changed the name of the flags. Please let me know if you want to request more change so I will give you the right access to edit my fork. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good.
Since we don't have a reviewer for the new additions of grib2 output, we will merge this PR as is and if issues arise, address them during retrospective evaluation. With this change, we will disable the generation of grib2 files via the use of |
Description
A new grib2 writer added to oceanicepost module. It uses g2 library to build grib2 files. The module doesn't need any grib2 template. The module fully tested for ocean and ice post processing. It works smoothly and quickly.
Type of change
Change characteristics
How has this been tested?
Fully tested both ocean and ice post processing modules. Grib2 files and data are generated correctly.
Checklist