Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grib2 writer for oceanicepost #99

Merged
merged 146 commits into from
Feb 28, 2025
Merged

Conversation

AminIlia-NOAA
Copy link
Contributor

Description

A new grib2 writer added to oceanicepost module. It uses g2 library to build grib2 files. The module doesn't need any grib2 template. The module fully tested for ocean and ice post processing. It works smoothly and quickly.

Type of change

  • New feature (adds functionality)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? YES
  • Does this change require a documentation update? NO

How has this been tested?

Fully tested both ocean and ice post processing modules. Grib2 files and data are generated correctly.

Checklist

  • [*] Any dependent changes have been merged and published
  • [*] My code follows the style guidelines of this project
  • [*] I have performed a self-review of my own code
  • [*] I have commented my code, particularly in hard-to-understand areas
  • [*] My changes generate no new warnings
  • [*] New and existing tests pass with my changes
  • [*] I have made corresponding changes to the documentation if necessary

Amin Ilia added 30 commits November 21, 2024 11:20
@aerorahul
Copy link
Contributor

I know grib2 fortran very well. Also, everything set correctly. Please go ahead and merge it into the main repo. Thanks!

Sounds good.
I will merge it and open an issue in the global-workflow to update the configuration to write out the grib2 file directly.
I will leave the validation for the retrospectives.

Copy link
Contributor

@aerorahul aerorahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments before we can merge.

@AminIlia-NOAA
Copy link
Contributor Author

@aerorahul I resolved the suggestions.

@aerorahul
Copy link
Contributor

@aerorahul I resolved the suggestions.

@AminIlia-NOAA
Thank you for resolving the comments. I have one additional comment regarding the output in netcdf.

@AminIlia-NOAA
Copy link
Contributor Author

@aerorahul added netcdf flag with default false.

Copy link
Contributor

@aerorahul aerorahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use netcdf (we don't have to be limited to 2-3 character names) to be more descriptive.

AminIlia-NOAA and others added 10 commits February 28, 2025 10:40
change name to netcdf

Co-authored-by: Rahul Mahajan <aerorahul@users.noreply.github.com>
change flag name to netcdf

Co-authored-by: Rahul Mahajan <aerorahul@users.noreply.github.com>
change flag name to netcdf

Co-authored-by: Rahul Mahajan <aerorahul@users.noreply.github.com>
change flag name to netcdf

Co-authored-by: Rahul Mahajan <aerorahul@users.noreply.github.com>
change flag name to netcdf

Co-authored-by: Rahul Mahajan <aerorahul@users.noreply.github.com>
change flag name to netcdf

Co-authored-by: Rahul Mahajan <aerorahul@users.noreply.github.com>
change flag name to netcdf

Co-authored-by: Rahul Mahajan <aerorahul@users.noreply.github.com>
change flag name to netcdf

Co-authored-by: Rahul Mahajan <aerorahul@users.noreply.github.com>
change flag name to netcdf

Co-authored-by: Rahul Mahajan <aerorahul@users.noreply.github.com>
@AminIlia-NOAA
Copy link
Contributor Author

@aerorahul ncf was ok as fortran compiler mixed netcdf flag with necdf lib module. I changed the name of flag to netcdff.

@aerorahul
Copy link
Contributor

@aerorahul ncf was ok as fortran compiler mixed netcdf flag with necdf lib module. I changed the name of flag to netcdff.

May I suggest, in that case, to replace netcdff with write_netcdf and grib2 with write_grib2.

@AminIlia-NOAA
Copy link
Contributor Author

@aerorahul I changed the name of the flags. Please let me know if you want to request more change so I will give you the right access to edit my fork. Thanks!

Copy link
Contributor

@aerorahul aerorahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

@aerorahul
Copy link
Contributor

Since we don't have a reviewer for the new additions of grib2 output, we will merge this PR as is and if issues arise, address them during retrospective evaluation. With this change, we will disable the generation of grib2 files via the use of wgrib2.

@aerorahul aerorahul merged commit c96bbc3 into NOAA-EMC:develop Feb 28, 2025
3 checks passed
@AminIlia-NOAA AminIlia-NOAA deleted the grib2w branch March 6, 2025 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants