Debugging checksum on full range of Kh_h and Kh_q #821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Expand range of halos for checksums for Kh_h, Kh_q, Ah_h and Ah_q to cover the full range of values that are actually used. Only debugging diagnostics are changed, and all answers are bitwise identical.
|
This PR failed TC testing due to uninitialized values in the halo regions. It is being closed and will be folded into a larger commit that addresses the problems with the uninitialized data. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simple PR expands the range of halos for the checksums for Kh_h, Kh_q, Ah_h and Ah_q to cover the full range of values that are actually used. Only debugging diagnostics are changed, and all answers are bitwise identical.