Dimensional rescaling in MOM_state_stats #830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hallberg-NOAA
added
the
refactor
herrwang0
approved these changes
Feb 15, 2025
MOM_state_stats() has been refactored to work primarily in dimensionally rescaled units using the unscale argument to reproducing_sum(). As a result of these changes, the units of 8 variables were changed to be rescaled, and six instances of multiplication by rescaling factors were changed into unscale arguments. MOM_state_stats() is exercised by setting DEBUG_CONSERVATION = True, and it has been verified that MOM_state_stats() gives results that are invariant to the use of dimensional rescaling. All answers and output are bitwise identical.
Hallberg-NOAA
force-pushed
the
refactor_MOM_state_stats
branch
from
ecd839c to
ab77091
Compare
|
This PR has passed pipeline testing at https://gitlab.gfdl.noaa.gov/ogrp/mom6ci/MOM6/-/pipelines/26404. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MOM_state_stats()has been refactored to work primarily in dimensionally rescaled units using theunscaleargument toreproducing_sum(). As a result of these changes, the units of 8 variables were changed to be rescaled, and six instances of multiplication by rescaling factors were changed intounscalearguments.MOM_state_stats()is exercised by settingDEBUG_CONSERVATION = True, and it has been verified thatMOM_state_stats()gives results that are invariant to the use of dimensional rescaling. All answers and output are bitwise identical.