+Obsoleted INTERNAL_TIDE_CORNER_ADVECT #831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hallberg-NOAA
added
documentation
raphaeldussin
approved these changes
Feb 12, 2025
This commit cleans up several aspects of the MOM_internal_tides code, including the elimination of one runtime option, the correction of some units in comments and a start toward enabling the propagation directions to alternate. 1. Eliminated the internal routine propagate_corner_spread. This routine was never completely implemented, and it has never been used in any realistic configurations. In particular, it appears that it will only work on a Cartesian grid in which the position variables (G%geoLonBu and G%geoLatBu) have the same units as G%dx. The comment describing propagate_corner_spread() indicates that "it is too numerically diffusive to be of much use as of yet" and that "it is not yet compatible with reflection schemes", so we have no plans to complete its implementation. Although it is being deleted, it can always be recovered from older branches of MOM6. 2. The runtime parameter INTERNAL_TIDE_CORNER_ADVECT, which triggered the use of propagate_corner_spread was obsoleted. 3. Started adding the option to alternate the direction of the internal tide propagation. The code that actually enacts the change is still commented out to avoid changing answers, but it could readily be enabled later with changes to a single line, and all the required code is present. 4. The units of 9 area-integrated energy budget debugging diagnostics were corrected, as is rescaling factor when their sum is written to stdout. With these changes, all answers are expected to be bitwise identical in any cases that are in active use, but an under-used runtime option has been eliminated from some MOM_parameter_doc files.
Hallberg-NOAA
force-pushed
the
internal_tides_cleanup
branch
from
ca135b4 to
db67260
Compare
|
This PR has passed pipeline testing at https://gitlab.gfdl.noaa.gov/ogrp/mom6ci/MOM6/-/pipelines/26369. (The warnings in that particular pipeline test about new parameters are inherited from the previous commit and can be safely ignored.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit cleans up several aspects of the MOM_internal_tides code, including the elimination of one runtime option, the correction of some units in comments and a start toward enabling the propagation directions to alternate.
Eliminated the internal routine
propagate_corner_spread(). This routine was never completely implemented, and it has never been used in any realistic configurations. In particular, it appears that it will only work on a Cartesian grid in which the position variables (G%geoLonBuandG%geoLatBu) have the same units asG%dx. The comment describingpropagate_corner_spread()indicates that "it is too numerically diffusive to be of much use as of yet" and that "it is not yet compatible with reflection schemes", so we have no plans to complete its implementation. Although it is being deleted, it can always be recovered from older branches of MOM6.The runtime parameter
INTERNAL_TIDE_CORNER_ADVECT, which triggered the use ofpropagate_corner_spread()was obsoleted.Started adding the option to alternate the direction of the internal tide propagation. The code that actually enacts the change is still commented out to avoid changing answers, but it could readily be enabled later with changes to a single line, and all the required code is present.
The units of 9 area-integrated energy budget debugging diagnostics were corrected, as is rescaling factor when their sum is written to
stdout.With these changes, all answers are expected to be bitwise identical in any cases that are in active use, but an under-used runtime option has been eliminated from some MOM_parameter_doc files.