Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct indenting in ePBL_column #836

Merged

Conversation

Hallberg-NOAA
Copy link
Member

@Hallberg-NOAA Hallberg-NOAA commented Feb 18, 2025

Corrected the indenting in most of the lines of ePBL_column to respect the MOM6 2-space indenting convention, and eliminated the comment explaining why the incorrect indenting had previously been retained to facilitate the review of a pull request with substantial actual changes in this routine. Apart from a single comment that was removed, only white space is changed, and all answers are bitwise identical.

(When reviewing the code changes in this pull request, I recommend the use of the "Hide whitespace" setting!)

Copy link

codecov bot commented Feb 18, 2025

Codecov Report

Attention: Patch coverage is 47.38462% with 171 lines in your changes missing coverage. Please review.

Project coverage is 38.10%. Comparing base (9924a19) to head (8f7ebe2).

Files with missing lines Patch % Lines
...c/parameterizations/vertical/MOM_energetic_PBL.F90 47.38% 128 Missing and 43 partials ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           dev/gfdl     #836   +/-   ##
=========================================
  Coverage     38.10%   38.10%           
=========================================
  Files           298      298           
  Lines         87644    87644           
  Branches      16418    16418           
=========================================
  Hits          33400    33400           
  Misses        48226    48226           
  Partials       6018     6018           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@marshallward marshallward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with the indentation change, and overall the style was otherwise preserved.

  Corrected the indenting in most of the lines of ePBL_column to respect the
MOM6 2-space indenting convention, and eliminated the comment explaining why the
incorrect indenting had previously been retained to facilitate the review of a
pull request with substantial actual changes in this routine.  Apart from a
single comment that was removed, only white space is changed, and all answers
are bitwise identical.
@Hallberg-NOAA
Copy link
Member Author

This PR has passed pipeline testing at https://gitlab.gfdl.noaa.gov/ogrp/mom6ci/MOM6/-/pipelines/26445.

@Hallberg-NOAA Hallberg-NOAA merged commit 51b1515 into NOAA-GFDL:dev/gfdl Feb 19, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants