Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Handle invalid GenBank accessions or missing RefSeq accessions in _resolve_genbank_accession() #308

Closed
wants to merge 10 commits into from

Conversation

liannette
Copy link
Contributor

Fixes issue #307 + additional issue

This PR addresses two different bugs in the _resolve_genbank_accession() function when resolving GenBank accession numbers to RefSeq accessions:

  1. The function previously failed when a valid GenBank accession existed in NCBI but had no corresponding RefSeq accession.
  2. It also broke when the provided GenBank accession was invalid (not found in NCBI).

Changes & Improvements:

  • Instead of causing an error, the function now returns an empty string ("") when no RefSeq accession is available.
  • Additional error handling cases have been added to improve robustness.
  • The function has been refactored for better readability and maintainability.

@liannette liannette marked this pull request as draft January 31, 2025 12:44
@liannette liannette closed this Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant