Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Go Dependencies #258

Merged
merged 1 commit into from
Feb 27, 2024
Merged

Update Go Dependencies #258

merged 1 commit into from
Feb 27, 2024

Conversation

rohit-arora-dev
Copy link
Collaborator

The purpose of this change is to update Golang dependencies. As part of this change CreateListener dependent on K8s utils in pkg/dcgmexporter/kubernetes_test.go file has been replaced by net package, thus reducing a number dependencies.

@nvvfedorov
Copy link
Collaborator

The purpose of this change is to update Golang dependencies. As part of this change CreateListener dependent on K8s utils in pkg/dcgmexporter/kubernetes_test.go file has been replaced by net package, thus reducing a number dependencies.

Good change!

Signed-off-by: Rohit Arora <roarora@nvidia.com>
Copy link
Collaborator

@nvvfedorov nvvfedorov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rohit-arora-dev rohit-arora-dev merged commit bd18649 into main Feb 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants