-
-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(livesync): enable livesync with bundling #3350
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 1, 2018
rosen-vladimirov
approved these changes
Feb 7, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
rosen-vladimirov
approved these changes
Feb 15, 2018
run ci |
ac0fc1b
to
800d9ce
Compare
run ci |
1 similar comment
run ci |
Enable LiveSync whenever a bundling plugin is present. Allow the bundling plugin to instruct CLI on what files should be watched and enable plugins to call `startSyncFilesTimeout` method in order to sync files modified by the bundling plugin itself.
800d9ce
to
5a2c054
Compare
run ci |
1 similar comment
run ci |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable LiveSync whenever a bundling plugin is present. Allow the bundling plugin to instruct CLI on what files should be watched and enable plugins to call
startSyncFilesTimeout
method in order to sync files modified by the bundling plugin itself.Enables #3349
Ping @KristianDD @rosen-vladimirov