Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(livesync): enable livesync with bundling #3350

Merged
merged 3 commits into from
Feb 27, 2018

Conversation

Mitko-Kerezov
Copy link
Contributor

Enable LiveSync whenever a bundling plugin is present. Allow the bundling plugin to instruct CLI on what files should be watched and enable plugins to call startSyncFilesTimeout method in order to sync files modified by the bundling plugin itself.

Enables #3349

Ping @KristianDD @rosen-vladimirov

Copy link
Contributor

@rosen-vladimirov rosen-vladimirov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@dtopuzov
Copy link
Contributor

run ci

@Mitko-Kerezov Mitko-Kerezov force-pushed the kerezov/webpack+livesync branch from ac0fc1b to 800d9ce Compare February 22, 2018 15:26
@rosen-vladimirov
Copy link
Contributor

run ci

1 similar comment
@dtopuzov
Copy link
Contributor

run ci

Dimitar Kerezov added 2 commits February 26, 2018 17:25
Enable LiveSync whenever a bundling plugin is present. Allow the bundling plugin to instruct CLI on what files should be watched and enable plugins to call `startSyncFilesTimeout` method in order to sync files modified by the bundling plugin itself.
@rosen-vladimirov
Copy link
Contributor

run ci

1 similar comment
@rosen-vladimirov
Copy link
Contributor

run ci

@Mitko-Kerezov Mitko-Kerezov merged commit 6a25723 into master Feb 27, 2018
@Mitko-Kerezov Mitko-Kerezov deleted the kerezov/webpack+livesync branch February 27, 2018 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants