Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If a hook throws an exception, onThreadStart called but onThreadComplete not #771

Closed
mattrjacobs opened this issue Apr 28, 2015 · 3 comments
Closed

If a hook throws an exception, onThreadStart called but onThreadComplete not #771

mattrjacobs opened this issue Apr 28, 2015 · 3 comments

Comments

@mattrjacobs
Copy link
Contributor

No description provided.

@mattrjacobs mattrjacobs mentioned this issue Apr 28, 2015
Merged
@mattrjacobs
Copy link
Contributor Author

Fixed by #772

@mattrjacobs mattrjacobs reopened this Apr 29, 2015
@mattrjacobs
Copy link
Contributor Author

The fix I made yesterday handles hook errors effectively, but it also prevents hooks from generating an exception that prevents execution of a command.

This limits the set of functionality that hooks offer needlessly. Instead of try-catching everything, it's likely better to let hooks throw an exception and do any state-management in a finally block

mattrjacobs pushed a commit to mattrjacobs/Hystrix that referenced this issue Apr 30, 2015
More precise solution to Netflix#771
92ecdac
mattrjacobs added a commit that referenced this issue Apr 30, 2015
@mattrjacobs
Merge pull request #780 from mattrjacobs/allow-hooks-to-throw-safely
57df50b 
More precise solution to #771
@mattrjacobs
Copy link
Contributor Author

Fixed by #780

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mattrjacobs