hystrix-contrib: hystrix-javanica (initial commit) #207
Conversation
|
Hystrix-pull-requests #67 SUCCESS |
|
Looks very cool! I'll be giving Hystrix some love in the near future and will review/merge. Thank you for contributing! |
|
Thanks for response! Hystrix is being actively used in our project, so I'll add annotation support for other Hystrix features like collapser and etc. in the near future. I think it's great chance to make Hystrix more user friendly. Thanks. |
|
I'm planning on doing this as part of 1.4 or a maintenance release before just to include this. I am doing a patch release today but not including this in it as it purposefully is staying focused on some bug fixes. |
|
Ok, lets see how it will be. How you gonna test it ? I wrote unit tests which exclude explicit bugs. Maybe you need some information or most tests? Please keep me posted about your concerns. It will be great if you include this changes in release candidate for example (I don't know which types of releases Hystrix has), it allows to get this lib from maven central repo and start testing in some real situation. It just in order to get some feedback and suggestions from users. Thanks. |
|
I have redesigned and improved the code. Also I've added logic to support collapser feature. I recently figured out that I made pull request in master branch, so I plan to make pull request with my changes in contributing branch. Thoughts ? |
|
Sure, that works. I am ready to merge and release this tomorrow (was about to try tonight). So if you submit a new PR I will merge and release 1.3.10 tomorrow. This should be the last release (theoretically) on 1.3.x before I merge 1.4 into master and do a beta release of 1.4. |
|
Closing and expecting a new PR. |
|
When can you provide the updated PR? |
|
I'll make PR on the 06.03.2014 (I mentioned exact date to exclude possible time-gaps), it's ok ? I can try to do this today 05.03.2014 tonight. |
|
In your personal fork, update the master branch so it is up to date, then branch that so you have a personal branch to make your changes to. Then submit that branch as a pull request. Thanks @dmgcodevil I may proceed with 1.3.10 before this and include your PR in 1.3.11 |
|
Yes, I understand that, but I gonna remove my branch and make commit in another branch because I made some inaccurate commits during development and I don't want to include them in commit history. Hence anyway I'll delete my branch and make clean commit again in another branch. So my question is in which branch (master or some other branch ) I should make commit and pull request ? If time would fail me to make PR today then you can merge it in 1.3.11. Thanks. |
|
You should be working off of master as I want it on the 1.3.x release line for now before I merge the 1.4.x branch into master. |
|
I've made #216 |
Base implementation includes features to create Hystrix commands using java annotations.
Read more about javanica