Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layout fixes #297

Merged
merged 10 commits into from
Nov 8, 2024
Merged

Layout fixes #297

merged 10 commits into from
Nov 8, 2024

Conversation

daringer
Copy link
Collaborator

  • information_box now with consistent height and font-sizes
  • consistent left margin for settings + secrets list/tree-view
  • overall properly set font-sizes across all views
  • increase font size in nk3-button on welcome view
  • redesign welcome page
  • corrected font size for algorithm drop-down to choose algorithm

@daringer daringer requested a review from mmerklinger October 21, 2024 15:15
@mmerklinger
Copy link
Collaborator

Screenshot from 2024-10-22 11-25-33

On Fedora 40 with Gnome desktop the dark mode has no effect, except for the title of the window. Turning on dark mode before or after the start of the app doesn't have an effect either.

@mmerklinger
Copy link
Collaborator

Screenshot from 2024-10-22 11-04-09

On Windows 11 without a connected Nitrokey the icon on the top left is misaligned and the text below it might not be perfectly centered.

@mmerklinger
Copy link
Collaborator

Screenshot from 2024-10-22 11-05-12

Screenshot from 2024-10-22 11-05-23

On Windows 11 the the container in the update window is cut off if the window size is reduced to the minimum size. When extended it will stop to expand at some fixed width.

@mmerklinger
Copy link
Collaborator

On Linux and Window the containers inside the Passwords and Settings tab have aligned containers. Changing from one of them to the Overview makes the container border jump a little bit. In the overview tab it seems that the elements have another container around them, because I can see a slight grey box around it.

@mmerklinger
Copy link
Collaborator

Could you please also remove the qt_material from the mypy override list in the pyproject.toml? It was originally changed in another PR, but I think it would fit thematically in this one.

@mmerklinger
Copy link
Collaborator

Could you please also remove the qt_material from the mypy override list in the pyproject.toml? It was originally changed in another PR, but I think it would fit thematically in this one.

Fixed in #307.

Copy link
Collaborator

@mmerklinger mmerklinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR tested on Fedora 41 and macOS 15.1. Minor problems left regarding dark mode. Overall great improvements.

@mmerklinger mmerklinger merged commit d8e5cde into main Nov 8, 2024
12 checks passed
@mmerklinger mmerklinger deleted the layout-fixes branch November 8, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants