Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gimpPlugins: clean up #103361

Merged
merged 4 commits into from
Nov 11, 2020
Merged

gimpPlugins: clean up #103361

merged 4 commits into from
Nov 11, 2020

Conversation

jtojnar
Copy link
Member

@jtojnar jtojnar commented Nov 10, 2020

Motivation for this change
  • gimp: expose gimpdatadir & gimplibdir
  • gimpPlugins: clean up using gimp.targetLibDir
  • gimpPlugins.lqrPlugin: 0.7.1 → 0.7.2

cc @erictapen

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jtojnar jtojnar mentioned this pull request Nov 10, 2020
Merged
10 tasks
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100 labels Nov 10, 2020
@jtojnar
gimpPlugins: include GIMP into the scope
aa96bd2 
So that it can be easily overridden.

Also clean up, update usage comment for this century and remove alias.
@jtojnar jtojnar mentioned this pull request Nov 11, 2020
Merged
10 tasks
@ofborg ofborg bot added 8.has: clean-up 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin labels Nov 11, 2020
@jtojnar jtojnar merged commit dfa9774 into NixOS:master Nov 11, 2020
@jtojnar jtojnar deleted the gimp-cleanup branch November 11, 2020 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: clean-up 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 11-100 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jtojnar @nixos-discourse