Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

discordphp: init at 7.3.5 #296707

Closed
wants to merge 1 commit into from
Closed

discordphp: init at 7.3.5 #296707

wants to merge 1 commit into from

Conversation

transgirllucy
Copy link

@transgirllucy transgirllucy commented Mar 17, 2024

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • [] Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@drupol
Copy link
Contributor

drupol commented Mar 17, 2024

Looks great! How do you use it in nix ?

@transgirllucy
Copy link
Author

Looks great! How do you use it in nix ?

i use it to build my discord bot with it on different systems with different distributions.

@drupol
Copy link
Contributor

drupol commented Mar 17, 2024

Great!

Copy link
Contributor

@drupol drupol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mind moving it to pkgs/by-name?

@transgirllucy
Copy link
Author

Do you mind moving it to pkgs/by-name?

How? Is there any documentation

@drupol
Copy link
Contributor

drupol commented Mar 17, 2024

Do you mind moving it to pkgs/by-name?

How? Is there any documentation

Sure,

  1. The nixpkgs repository is full of commits that you can use as example
  2. The RFC: [RFC 0140] Simple Package Paths rfcs#140

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants