nixos: use substitute
rather than substituteAll
in installer modules
#300329
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Rationale is here:
substituteAll
is a terrible function and we need to stop using it / fix it respectively #237216There's mostly no change to the files. I did make two bug fixes:
nixos/modules/installer/tools/nixos-install.sh
, there is nonix
replacement variable, but there is a path substitution, so I addedconfig.nix.package.out
to the path.nixos/modules/installer/tools/nixos-enter.sh
, there was nopath
replacement variable; I added it.These changes validate the logic that motivated opening #237216. It's too easy to write a bug!
Previously:
substitute
rather thansubstituteAll
#300308substitute
rather thansubstituteAll
, fix cross-compilation #300322Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)