treewide: replace substituteAll with replaceVars (part 2) #373658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: GNOME
|
Driving NixOS#237216 forward.
wolfgangwalther
force-pushed
the
refactor-tractor-2
branch
from
1ebe754 to
90ef4b5
Compare
wolfgangwalther
commented
Jan 14, 2025
philiptaron
approved these changes
Jan 14, 2025
wegank
added
the
12.approvals: 1
|
I double checked that all touched packages were part of the nixpkgs-review, thus no conditionals prevented building some of them. ✔️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the road again, driving #237216 forward. Continuation of #365440. Same approach: Auto-generated changes, removed all of those that would require adjustments.
The number of changed packages should still allow to build this via nixpkgs-review.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.