linuxPackages.e1000e: 3.3.5.3 -> 3.8.4

[lorenzleutgeb]

Upgrade e1000e from version 3.3.5.3 to 3.8.4

Motivation for this change

I got a new laptop that requires a newer version of e1000e, and I saw that the derivation hasn't been updated in a while.

Things done

I am a new NixOS user and struggling to test this.

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Determined the impact on package closure size (by running nix path-info -S before and after)
• Ensured that relevant documentation is up to date
• Fits CONTRIBUTING.md.

[nh2]

@GrahamcOfBorg build

[nh2]

Result of nixpkgs-review pr 91444 1

2 packages failed to build:

- linuxPackages_4_4.e1000e
- linuxPackages_4_9.e1000e

[nh2]

I get this when building with nixpkgs-review above:

  source root is e1000e-3.8.4
  setting SOURCE_DATE_EPOCH to timestamp 1584260392 of file e1000e-3.8.4/SUMS
  patching sources
  configuring
  building
  build flags: -j12 -l12 SHELL=/nix/store/5hplxs3kprdp6v62qk3di6a1m1s1paiq-bash-4.4-p23/bin/bash BUILD_KERNEL=4.9.228
  common.mk:85: *** Kernel header files not in any of the expected locations.
  common.mk:86: *** Install the appropriate kernel development package, e.g.
  common.mk:87: *** kernel-devel, for building kernel modules and try again.  Stop.
  builder for '/nix/store/d1nvrxcj25g41qxqhz4dnfn261xmcdzh-e1000e-3.8.4-4.9.228.drv' failed with exit code 2

[lorenzleutgeb]

Thank you for your feedback. I am new to NixOS, and this is my first (tentative) contribution to nixpkgs, so I appreciate your guiding comments.

To recreate the failure on my machine I used nixpkgs-review. I then amended my earlier commit to fix the issue, and ran nixpkgs-review rev HEAD which resulted in:

...
2 packages updated:
linuxPackages_4_4.e1000e (3.3.5.3-4.4.228 → 3.8.4-4.4.228) ↩
linuxPackages_4_9.e1000e (3.3.5.3-4.9.228 → 3.8.4-4.9.228)
...

(Newline added by me, for readbility.)

I interpreted this output as an indication that my fix indeed works and force-pushed. Please check again.

Another (slightly off-topic) question: I am running Linux 5.7.4 (via boot.kernelPackages = pkgs.linuxPackages_latest) and am wondering whether my changes to e1000e will be available with Linux 5.7.4 as well, since the output (pasted above) only talks about 4.4 and 4.9. Probably I do not understand how pkgs.linuxPackages_* is constructed well enough. Could you please give me some direction for my research?

[danieldk]

Thank you for your first submission 👍 . Sorry that you have to wait so long for progress on this PR. I have added one suggested change.

Feel free to re-request a review once you have made the changes.

[danieldk]

LGTM

Result of nixpkgs-review pr 91444 1

2 packages built:

- linuxPackages_4_4.e1000e
- linuxPackages_4_9.e1000e

I can't test the module, since I do not have the hardware. But since this is directly coming from the vendor it should be fine.