script checking for standard EUOUAE lyrics and consistent tones #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xmarteo
reviewed
Jul 6, 2023
| last_section = chant.sections[-1] | ||
| lyrics = assembleLyrics(last_section) | ||
| has_euouae = 'E U O U A E.' in lyrics | ||
| # TODO: is there a rule which ones have EUOUAE and which Et sic finiatur? |
There was a problem hiding this comment.
EUOUAE is replaced with Et sic finiatur if and only if the GP is omitted at the end of the psalm, which occurs only in Tenebrae (and other hours in the Triduum) and in O.Def.
There are antiphons that I had to duplicate (they are soft-linked through the database website of nocturnale.marteo.fr) because they are used in a context with GP and in another without (e.g. Tenebrae antiphons also used in Our Lady of Sorrows).
|
I didn't realize there are that many files chant21 is currently not capable of parsing. That's not an issue to be solved quickly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This kind of consistency assurance
Nocturnale-Romanum/nocturnale-romanum@a29baa0
should never be left to humans, so I started work on a script checking for EUOUAE consistency.
Right now it still reports a lot of false positives, but I hope to learn more about music21 and have them fixed soon.