Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Appease two remaining Clippy lints #689

Merged
merged 6 commits into from
Dec 4, 2023
Merged

Appease two remaining Clippy lints #689

merged 6 commits into from
Dec 4, 2023
+35 −29

Conversation

Xanewok
Copy link
Contributor

@Xanewok Xanewok commented Dec 2, 2023

Part of #155

Leaving the needless_return for a dedicated PR.

@Xanewok
Appease two remaining Clippy lints
582b02f
@Xanewok
Introduce a WithColor::{Yes,No} argument helper for error rendering
88c654d 
If we're already always using the comment to specify the argument name,
we might as well use a named enum to convey the meaning directly.

This is opt-in - we can continue to pass regular boolean by using the
`Into<bool>` rather than accepting only `WithColor` arguments.
@Xanewok Xanewok requested a review from a team as a code owner December 2, 2023 17:30
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 2, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: ae42770

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

OmarTawfik
OmarTawfik reviewed Dec 3, 2023
View reviewed changes
Copy link
Contributor

@OmarTawfik OmarTawfik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few suggestions.

@Xanewok Xanewok changed the title Appease two Clippy lints and introduce a helper WithColor enum Appease two Clippy lints Dec 4, 2023
@Xanewok Xanewok changed the title Appease two Clippy lints Appease two remaining Clippy lints Dec 4, 2023
OmarTawfik
OmarTawfik approved these changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@OmarTawfik OmarTawfik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! thanks!

@Xanewok
Copy link
Contributor Author

Xanewok commented Dec 4, 2023

Left a note in ae42770 that says we should move to [lints] once we upgrade to Rust 1.74.

@Xanewok Xanewok enabled auto-merge December 4, 2023 17:35
@Xanewok Xanewok added this pull request to the merge queue Dec 4, 2023
Merged via the queue into NomicFoundation:main with commit e984f14 Dec 4, 2023
@Xanewok Xanewok deleted the clippy-followup branch December 4, 2023 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OmarTawfik OmarTawfik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Xanewok @OmarTawfik