Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][DEL][l10n_br_fiscal]: remove empty mixin lines onchanges #3655

Merged
merged 1 commit into from
Mar 20, 2025

Conversation

rvalyi
Copy link
Member

@rvalyi rvalyi commented Mar 15, 2025

Uns anos atrás, o @renatonlima tinha preparado esses onchange nas linhas dos documentos fiscais como pontos de extensões a serem customizados. Porem, eu acho melhor tirar pois:

  • engorda o Javascript/memoria dos forms das linhas de documentos fiscais/mixins
  • cria um montão de eventos XHR/AJAX com entre o cliente e o server para no final das contas fazer nada a não ser deixar deixar tudo mais lento.
  • se vc quiser implementar um daqueles onchanges, vc pode fazer lo sem chamar algum super. Ter esses vazios não acrescenta nada a não ser sugerir de fazer
  • engorda o código de forma desnecessária

Eu diria que a única duvida que cabe é se vale a pena deixar esses métodos comentados como eu fiz para documentar que é possível implementar. Não sei se vale bem a pena...

@OCA-git-bot
Copy link
Contributor

Hi @renatonlima,
some modules you are maintaining are being modified, check this out!

@rvalyi rvalyi changed the title [16.0][DEL][l10n_br_fiscal]: remove empty onchanges [16.0][DEL][l10n_br_fiscal]: remove empty mixin lines onchanges Mar 15, 2025
@rvalyi rvalyi force-pushed the 16.0-doc-line-rm-empty-onchanges branch 3 times, most recently from 5da7aa8 to 1f4eb5c Compare March 15, 2025 19:57
@rvalyi rvalyi force-pushed the 16.0-doc-line-rm-empty-onchanges branch from 78a9c57 to 0a8d638 Compare March 15, 2025 20:27
@rvalyi
Copy link
Member Author

rvalyi commented Mar 17, 2025

@renatonlima ok com esse?

@rvalyi rvalyi requested a review from renatonlima March 17, 2025 11:13
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@renatonlima
Copy link
Member

Eu havia implementado esses métodos para futuramente implementar a funcionalidade de informar os valores dos impostos manualmente, mas como na versão 16.0 é possível fazer com compute, acho que faz sentido remove-los.

@renatonlima
Copy link
Member

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-3655-by-renatonlima-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 797cf1b into OCA:16.0 Mar 20, 2025
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at eee7f94. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants