Make sure that pip always gets upgraded

[stweil]

It was not upgraded for an existing venv.

Signed-off-by: Stefan Weil sw@weilnetz.de

[bertsky]

Why not. But I wonder what your use-case is. We never needed to update from the old 9-something default until recently. Does this have to do with the new dependency resolver that will arrive by default soon?

[stweil]

We never needed to update from the old 9-something default until recently.

Maybe most builds did not use an existing venv but created the venv? The Makefile already upgraded pip when it created a new venv.

[bertsky]

We never needed to update from the old 9-something default until recently.

Maybe most builds did not use an existing venv but created the venv? The Makefile already upgraded pip when it created a new venv.

No, creating a venv does not update pip automatically. We only noticed this when the old default version (it's 9.0.1 under Ubuntu 18.04) both pre-built wheels in the manylinux2014 format and fallback installation from source distributions using pyproject.toml stopped working.

[stweil]

No, creating a venv does not update pip automatically.

The current Makefile creates the venv in line 141. Line 142 updates pip. I don't understand your no.

[bertsky]

We never needed to update from the old 9-something default until recently.

No, creating a venv does not update pip automatically.

The current Makefile creates the venv in line 141. Line 142 updates pip. I don't understand your no.

You are taking this out of context. The question remains: what do we need this change for in the first place?

[stweil]

The question remains: what do we need this change for in the first place?

See the commit message: pip was not upgraded for an existing venv. So for example this sequence would run with an old version of pip and possibly fail:

python3.7 -m venv myvenv
source myvenv/bin/activate
make all