LABEL the image with git rev, build date, maintainer, microbadger bad… #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stweil
requested changes
Jan 8, 2020
Looks great. Isn't that also something to at least recommend in docker.md for all modules? (Otherwise you never know which version to pull...) |
Absolutely. I'll open an issue to remember. |
stweil
approved these changes
Jan 8, 2020
|
Is this PR ready for merging? |
Yes, I cancelled the build yesterday so it didn't hog the queue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will add labels to the container with build date and git revision that can be inspected with
docker inspect- might be useful for debugging.MAINTAINERis deprecated. Additional benefit is that this is compatible with microbadger which displays docker image info in a shields.io-like badge in the README.