Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Makefile: Add deps-ubuntu rule for ocrd_pagetopdf submodule #97

Merged
merged 1 commit into from
May 22, 2020
Merged

Makefile: Add deps-ubuntu rule for ocrd_pagetopdf submodule #97

merged 1 commit into from
May 22, 2020

Conversation

sulzbals
Copy link
Contributor

As discussed in UB-Mannheim/ocrd_pagetopdf#12 (Better wait for that one to get merged before merging this).

@bertsky bertsky self-requested a review May 18, 2020 20:37
bertsky
bertsky requested changes May 18, 2020
View reviewed changes
Copy link
Collaborator

@bertsky bertsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to also update the submodule to your version and commit it.

Plus it is generally preferable to wait for a merge with master in the module itself (exception proves the rule).

@stweil stweil merged commit 92787d0 into OCR-D:master May 22, 2020
@stweil
Copy link
Collaborator

stweil commented May 22, 2020

Thanks, merged now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bertsky bertsky bertsky requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sulzbals @stweil @bertsky