Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check for empty line image, ht @andbue, fix #48 #49

Merged
merged 1 commit into from
Jan 20, 2021
Merged

Conversation

kba
Copy link
Member

@kba kba commented Dec 17, 2020

@jbarth-ubhd Can you please verify that this fixes Calamari-OCR/calamari#193 / #48 for you?

@codecov-io
Copy link

Codecov Report

Merging #49 (df53087) into master (1c7fcda) will increase coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #49      +/-   ##
==========================================
+ Coverage   88.46%   88.53%   +0.07%     
==========================================
  Files           2        2              
  Lines         156      157       +1     
  Branches       36       36              
==========================================
+ Hits          138      139       +1     
  Misses         11       11              
  Partials        7        7              
Impacted Files Coverage Δ
ocrd_calamari/recognize.py 88.23% <100.00%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c7fcda...df53087. Read the comment docs.

@jbarth-ubhd
Copy link

@kba: are you using github cli, too?

[hd_xxxxx@login5 ocrd_calamari]$ ~/gh_1.4.0_linux_amd64/bin/gh pr checkout 49
remote: Enumerating objects: 4, done.
remote: Counting objects: 100% (4/4), done.
remote: Total 4 (delta 3), reused 4 (delta 3), pack-reused 0
Entpacke Objekte: 100% (4/4), 418 Bytes | 2.00 KiB/s, Fertig.
Von https://github.com/OCR-D/ocrd_calamari
 * [neuer Branch]    fix-48     -> origin/fix-48
Vorherige Position von HEAD war 1c7fcda 📝 README: Link to model download
Zu neuem Branch 'fix-48' gewechselt

@jbarth-ubhd
Copy link

jbarth-ubhd commented Dec 21, 2020

what should I do?

[hd_xxxxx@login5 ocrd_all]$ make OCRD_MODULES=ocrd_calamari NO_UPDATE=1 all
make: Nothing to be done for `all'.

but without NO_UPDATE=1 I'll assume version of ocrd_calamari will be set back...

@kba
Copy link
Member Author

kba commented Dec 21, 2020

what should I do?

[hd_xxxxx@login5 ocrd_all]$ make OCRD_MODULES=ocrd_calamari NO_UPDATE=1 all
make: Nothing to be done for `all'.

but without NO_UPDATE=1 I'll assume version of ocrd_calamari will be set back...

Quick way to trigger a rebuild is to remove the ocrd-calamari-recognize wrapper:

rm venv/bin/ocrd-calamari-recognize
make all OCRD_MODULES=ocrd_calamari NO_UPDATE=1

@jbarth-ubhd
Copy link

yes, this pr helps for calamari#193, but not for

» ValueError: Error when checking input: expected input_1 to have shape (448, 896, 3) but got array with shape (448, 4, 3)
https://digi.ub.uni-heidelberg.de/diglitData/v/ocrd/lichtwark1932bd2_-_h.tif«.

I will open a separate case for that.

@mikegerber
Copy link
Collaborator

I'll check this PR this week.

@mikegerber
Copy link
Collaborator

This fixed #48, merging!

@mikegerber mikegerber merged commit a014bab into master Jan 20, 2021
@mikegerber mikegerber deleted the fix-48 branch January 20, 2021 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: int() argument must be a string, a bytes-like object or a number, not 'Image'
4 participants