-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EAR-2352 - Piping introduction page #3110
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sudeep <sudeep.kunhikannan@ons.gov.uk>
Signed-off-by: sudeep <sudeep.kunhikannan@ons.gov.uk>
Signed-off-by: sudeep <sudeep.kunhikannan@ons.gov.uk>
Signed-off-by: sudeep <sudeep.kunhikannan@ons.gov.uk>
…m/ONSdigital/eq-author-app into EAR-2352-piping-introduction-page
Signed-off-by: sudeep <sudeep.kunhikannan@ons.gov.uk>
farres1
previously approved these changes
May 20, 2024
Signed-off-by: sudeep <sudeep.kunhikannan@ons.gov.uk>
…m/ONSdigital/eq-author-app into EAR-2352-piping-introduction-page
farres1
approved these changes
May 20, 2024
Paul-Joel
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the context of this PR?
https://jira.ons.gov.uk/browse/EAR-2352
How to review
- After switching to the 'EAR-2352-piping-introduction-page' branch, make the below changes in the local files in 'eq-author-app/eq-author-api' and then restart api using 'docker-compose up'
<file-name>.json
with the file name from the above step.- Make the below changes in the local eq-questionnaire-runner application and restart using 'docker-compose up --build'
Paste the above JSON file in the 'eq-questionnaire-runner' directory where the 'docker-compose.yml' is present
In the 'docker-compose.yml' file, replace the below line
SDS_API_BASE_URL: https://34.36.133.231.nip.io
In the file '.development.env', replaces the lines from 30 onwards with the below, in the
<file-name>.json
, replace using the above JSON file nameSwitch the 'eq-publisher-v3' application to the 'EAR-2352-piping-introduction-page' branch and restart the application
Create a new questionnaire, in the Settings page, set the survey id as '221'.
In the 'Data' page, in the 'Sample file data' tab, add a new key called 'sds_dataset_id' with the value '6731a2aa-d754-4ed1-b5e3-4b76a540fb6c'
Set the 'ru_ref' key value as '34942807969'
In the 'Data' page, in the 'Supplementary data' tab, select the survey id '221 - BRES' in the dropdown and link the dataset.
In the Introduction page, go to Title field, click on 'Pipe metadata' and select 'Answer from supplementary data'
The fields starting with 'local-units' should now be available for piping, select any one, for example, 'local-units - name'.
Now launch the survey, the introduction page should display the title with the comma separated piped in values from the linked dataset.