Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zarr_driver.py: Minor cleanup. #11896

Merged
merged 2 commits into from
Mar 6, 2025
Merged

Conversation

schwehr
Copy link
Member

@schwehr schwehr commented Mar 1, 2025

  • Break up massive wkt string in test_zarr_read_crs
  • Wrap a few places with gdal.quiet_errors where ZARR_V3 gives "Warning 1: fill_value = null is invalid" on open
  • Remove a commented out debugging print

@schwehr schwehr requested review from sgillies and dbaston March 1, 2025 17:51
- Break up massive wkt string in test_zarr_read_crs
- Wrap a few places with gdal.quiet_errors where ZARR_V3 gives
  "Warning 1: fill_value = null is invalid" on open
- Remove a commented out debugging print
@schwehr schwehr force-pushed the zarr-test-cleanup branch from fc4742b to 566fe9c Compare March 5, 2025 21:05
Changes the quiet_errors from 566fe9c
now that 1c404c6 is in.
@coveralls
Copy link
Collaborator

Coverage Status

coverage: 70.335% (-0.01%) from 70.349%
when pulling dc18f99 on schwehr:zarr-test-cleanup
into e873236 on OSGeo:master.

@schwehr schwehr merged commit fd803f4 into OSGeo:master Mar 6, 2025
38 checks passed
@schwehr schwehr deleted the zarr-test-cleanup branch March 6, 2025 01:26
Jwohnlf pushed a commit to Jwohnlf/gdal that referenced this pull request Mar 23, 2025
* zarr_driver.py: Minor cleanup.

- Break up massive wkt string in test_zarr_read_crs
- Wrap a few places with gdal.quiet_errors where ZARR_V3 gives
  "Warning 1: fill_value = null is invalid" on open
- Remove a commented out debugging print

* zarr_driver.py: Convert some quiet_errors to quiet_warnings.

Changes the quiet_errors from 566fe9c
now that 1c404c6 is in.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants