Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add typescript declarations #30

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add typescript declarations #30

wants to merge 1 commit into from

Conversation

paolotiu
Copy link

@paolotiu paolotiu commented Jul 8, 2021

No description provided.

Copy link
Member

@jofftiquez jofftiquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thank you for this PR. Really great help. Just a few comments and this is good to go.

Along with the comments above, please include the following as well:

  1. Use 2 spaces for tabs.
  2. Run the linter before pushing.

@@ -0,0 +1 @@
export * from "./payment-intents";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use single quote ' instead of double quotes ". Thanks.

@@ -0,0 +1 @@
export * from "./payment-methods";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use single quote ' instead of double quotes ". Thanks.

@@ -0,0 +1 @@
export * from "./payments";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use single quote ' instead of double quotes ". Thanks.

@@ -0,0 +1 @@
export * from "./sources";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use single quote ' instead of double quotes ". Thanks.

@@ -0,0 +1 @@
export * from "./tokens";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use single quote ' instead of double quotes ". Thanks.

@@ -0,0 +1 @@
export * from "./webhooks";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use single quote ' instead of double quotes ". Thanks.

@jofftiquez
Copy link
Member

Hello @paolotiu thanks for this, I'm not an expert in TS so please let me know if there are invalid comments from what I added above. Thanks again.

@paolotiu
Copy link
Author

paolotiu commented Jul 8, 2021

Hello @paolotiu thanks for this, I'm not an expert in TS so please let me know if there are invalid comments from what I added above. Thanks again.

Hello @jofftiquez, the declaration files are auto-generated. As far as I know, there isn't an option to change the code style. I could change it manually, but it would be reset on the next build. Thank you!

@micahbule
Copy link
Contributor

Hi @jofftiquez, no updates on this one if ever? Thanks.

@jofftiquez
Copy link
Member

Hi @jofftiquez, no updates on this one if ever? Thanks.

Hello, there's no updates in the PR comments yet. But if you can check them so we can merge them immediately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants