-
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add typescript declarations #30
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, thank you for this PR. Really great help. Just a few comments and this is good to go.
Along with the comments above, please include the following as well:
- Use 2 spaces for tabs.
- Run the linter before pushing.
@@ -0,0 +1 @@ | |||
export * from "./payment-intents"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use single quote '
instead of double quotes "
. Thanks.
@@ -0,0 +1 @@ | |||
export * from "./payment-methods"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use single quote '
instead of double quotes "
. Thanks.
@@ -0,0 +1 @@ | |||
export * from "./payments"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use single quote '
instead of double quotes "
. Thanks.
@@ -0,0 +1 @@ | |||
export * from "./sources"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use single quote '
instead of double quotes "
. Thanks.
@@ -0,0 +1 @@ | |||
export * from "./tokens"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use single quote '
instead of double quotes "
. Thanks.
@@ -0,0 +1 @@ | |||
export * from "./webhooks"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use single quote '
instead of double quotes "
. Thanks.
Hello @paolotiu thanks for this, I'm not an expert in TS so please let me know if there are invalid comments from what I added above. Thanks again. |
Hello @jofftiquez, the declaration files are auto-generated. As far as I know, there isn't an option to change the code style. I could change it manually, but it would be reset on the next build. Thank you! |
Hi @jofftiquez, no updates on this one if ever? Thanks. |
Hello, there's no updates in the PR comments yet. But if you can check them so we can merge them immediately. |
No description provided.