Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(sdk): upgrade dependency versions to support node22 #13232

Merged
merged 2 commits into from
Feb 19, 2025
Merged

Conversation

nliu-ms
Copy link
Contributor

@nliu-ms nliu-ms commented Feb 18, 2025

https://msazure.visualstudio.com/Microsoft%20Teams%20Extensibility/_workitems/edit/31295537

Manually test following templates:

ts/notification-express
samples/team-central-dashboard(tab-sso)

Upgrade botbuilder to 4.23.2
image

===================================================================
Note: there is a breaking change in node22:
Use "with" syntax instead of "assert" nodejs/node#51622
image

Now we use node18 in cd pipelines, if it's upgrade to node22, we need to update rollup.config.mjs

Copy link

codecov bot commented Feb 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.26%. Comparing base (6043fdc) to head (22c7157).
Report is 7 commits behind head on dev.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev   #13232      +/-   ##
==========================================
- Coverage   90.26%   90.26%   -0.01%     
==========================================
  Files         603      603              
  Lines       35739    35749      +10     
  Branches     6956     7051      +95     
==========================================
+ Hits        32261    32269       +8     
- Misses       1513     1514       +1     
- Partials     1965     1966       +1     

see 4 files with indirect coverage changes

@nliu-ms nliu-ms marked this pull request as ready for review February 19, 2025 03:27
@nliu-ms nliu-ms changed the title feat(sdk): upgrade dependency versions to suport node22 build(sdk): upgrade dependency versions to suport node22 Feb 19, 2025
@nliu-ms nliu-ms merged commit 5512fab into dev Feb 19, 2025
31 checks passed
@nliu-ms nliu-ms deleted the nliu/sdk branch February 19, 2025 05:33
@nliu-ms nliu-ms changed the title build(sdk): upgrade dependency versions to suport node22 build(sdk): upgrade dependency versions to supPort node22 Feb 25, 2025
@nliu-ms nliu-ms changed the title build(sdk): upgrade dependency versions to supPort node22 build(sdk): upgrade dependency versions to support node22 Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants