Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[aspnetcore] Remove web.config #6214

Merged
merged 1 commit into from
May 8, 2020
Merged

[aspnetcore] Remove web.config #6214

merged 1 commit into from
May 8, 2020

Conversation

wing328
Copy link
Member

@wing328 wing328 commented May 8, 2020

As discussed in https://github.com/OpenAPITools/openapi-generator/pull/6147/files#pullrequestreview-404619471

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

cc @jimschubert, @frankyjuang, @shibayan

@wing328 wing328 added this to the 5.0.0 milestone May 8, 2020
@wing328 wing328 changed the title Remove web.config [aspnetcore] Remove web.config May 8, 2020
Copy link
Contributor

@shibayan shibayan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@wing328 wing328 merged commit d6d241b into master May 8, 2020
@wing328 wing328 deleted the csharp-webconfig branch May 8, 2020 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants