Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Init variables which can be later used uninitialized #26

Merged
merged 2 commits into from
Feb 9, 2024

Conversation

zdohnal
Copy link
Member

@zdohnal zdohnal commented Feb 7, 2024

I ran openscanhub tool on cups-browsed code and fixed some of the important issues it reports - usage of uninitialized memory in the code.

Here are results - I didn't fix Y2K38_SAFETY and REVERSE_NEGATIVE, because:

Y2K38_SAFETY: timeout used there will never be that high to overflow - it is subtraction of current time from expected timeout of queue.

REVERSE_NEGATIVE: the value mentioned there comes from Avahi, so Avahi should take care of it being in valid interval.

@tillkamppeter tillkamppeter merged commit 8897825 into OpenPrinting:master Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants