-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scheduler: add a systemd slice #1035
Conversation
e87992e
to
92a38af
Compare
I don't have strong feelings about this, but just for grins what happens if the version of systemd in use doesn't support slices? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not approving yet - the main question I have is, "what happens if the version of systemd in use doesn't support slices?"
According to
It's unclear to me whether units with an unknown suffix are ignored (but I would assume they are). (Side note: It looks like they were introduced in v205, released in 2013.) |
92a38af
to
cd6e008
Compare
From the systemd documentation[1]: > A slice unit is a concept for hierarchically managing resources of a group of processes. Benefits of collecting our two systemd services into a slice include * ease of configuring resource limits on the entire CUPS system, * ``systemctl status`` showing the CUPS units in an indented subtree, making it more organized, * and the possibility of viewing all interlaced logs from all of the CUPS daemons using ``journalctl -u system-cups.slice``. [1]: https://www.freedesktop.org/software/systemd/man/latest/systemd.slice.html or ``man systemd.slice(5)``
cd6e008
to
3aca5db
Compare
AFAIK cups-lpd is rarely used (I have not seen it used in older environments, only cupsd and lpd backend for a destination) and going to be removed in 3.0, so I'm not sure if many users see the systemd slice benefits, but it does not harm to have it... |
I am also planning on adding the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
See OpenPrinting/cups#1035 for rationale and an explanation. The ``system-cups.slice`` file included in the aformentioined PR is not required; the ``system-cups`` slice will be automatically created if the file is missing.
See OpenPrinting/cups#1035 for rationale and an explanation. The ``system-cups.slice`` file included in the aforementioned PR is not required; the ``system-cups`` slice will be automatically created if the file is missing.
See OpenPrinting/cups#1035 for rationale and an explanation. The ``system-cups.slice`` file included in the aforementioned PR is not required; the ``system-cups`` slice will be automatically created if the file is missing.
See OpenPrinting/cups#1035 for rationale and an explanation. The ``system-cups.slice`` file included in the aforementioned PR is not required; the ``system-cups`` slice will be automatically created if the file is missing.
- Works around CVE-2024-47176 (GHSA-rj88-6mr5-rcw8). - One additional commit fixing OpenPrinting/cups#1035 included.
From the systemd documentation[1]:
Benefits of collecting our two systemd services into a slice include
systemctl status
showing the CUPS units in an indented subtree, making it more organized,journalctl -u system-cups.slice
.[1]:
https://www.freedesktop.org/software/systemd/man/latest/systemd.slice.html or
man systemd.slice(5)