Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMake build is missing key features to be properly usable via FetchContent #550

Closed
globberwops opened this issue Jul 17, 2021 · 0 comments · Fixed by #551
Closed

CMake build is missing key features to be properly usable via FetchContent #550

globberwops opened this issue Jul 17, 2021 · 0 comments · Fixed by #551

Comments

@globberwops
Copy link
Contributor

Describe the bug

The CMake build is missing key features to be properly usable via CMake's FetchContent module.

Describe how to reproduce the bug

Steps to reproduce the behavior:

  1. In a downstream CMake project, do
include(FetchContent)
FetchContent_Declare(
  open-simulation-interface
  GIT_REPOSITORY https://github.com/OpenSimulationInterface/open-simulation-interface.git
  GIT_TAG v3.3.1
)
FetchContent_MakeAvailable(open-simulation-interface)
  1. This will
    a. pollute your upstream project's cache with non-prefixed variables INSTALL_LIB_DIR, INSTALL_INCLUDE_DIR, and INSTALL_CMAKE_DIR
    b. not provide namespaced alias targets e.g. open-simulation-interface::static
    c. not install the export set with a namespace
    d. pollute the downstream project's build with an unnecessary, redundant warning:

    open-simulation-interface/CMakeLists.txt

    Line 186 in ab60959

    message(WARNING "Doxygen could not be found.")

Describe the expected behavior

  1. prefix cache variables with the project name
  2. provide namespaced alias targets usable from the build tree
  3. provide a namespace for the export set
  4. do not warn unnecessarily
globberwops added a commit to globberwops/open-simulation-interface that referenced this issue Jul 17, 2021
@globberwops
OpenSimulationInterface#550 Prefix cache variables with OSI_ identifier
f4034eb 
* Prefix cache variables with OSI_ identifier
* Use option() to set cache variables

Signed-off-by: Martin Stump <11492152+globberwops@users.noreply.github.com>
globberwops added a commit to globberwops/open-simulation-interface that referenced this issue Jul 20, 2021
@globberwops
OpenSimulationInterface#550 Provide namespaced aliases for all targets
642fb1b 
Signed-off-by: Martin Stump <11492152+globberwops@users.noreply.github.com>
globberwops added a commit to globberwops/open-simulation-interface that referenced this issue Jul 20, 2021
@globberwops
OpenSimulationInterface#550 Rewrite the whole installation logic
d0ecf4c 
* Fix the cache variables
* Copy the headers to the appropriate location in the PROJECT_BINARY_DIR
* Rewrite the package config file template
* Create proper config, version, and target files
  using CMakePackageConfigHelpers
* Export and install namespaced targets

Signed-off-by: Martin Stump <11492152+globberwops@users.noreply.github.com>
globberwops added a commit to globberwops/open-simulation-interface that referenced this issue Jul 20, 2021
@globberwops
OpenSimulationInterface#550 Remove redundant warning about Doxygen
7ba9fca 
Signed-off-by: Martin Stump <11492152+globberwops@users.noreply.github.com>
globberwops added a commit to globberwops/open-simulation-interface that referenced this issue Jul 20, 2021
@globberwops
OpenSimulationInterface#550 Add compile_commands.json to ignore list
0898748 
Signed-off-by: Martin Stump <11492152+globberwops@users.noreply.github.com>
globberwops added a commit to globberwops/open-simulation-interface that referenced this issue Jul 20, 2021
@globberwops
OpenSimulationInterface#550 Configure osi_version.proto.in in binary dir
9978576 
Signed-off-by: Martin Stump <11492152+globberwops@users.noreply.github.com>
@globberwops globberwops mentioned this issue Jul 20, 2021
Merged
6 tasks
globberwops added a commit to globberwops/open-simulation-interface that referenced this issue Sep 8, 2021
@globberwops
OpenSimulationInterface#550 Merge latest master branch from upstream
4aae7d4 
Signed-off-by: Martin Stump <11492152+globberwops@users.noreply.github.com>
globberwops added a commit to globberwops/open-simulation-interface that referenced this issue Sep 8, 2021
@globberwops
OpenSimulationInterface#550 Fix flatbuffers option
0255c82 
Signed-off-by: Martin Stump <11492152+globberwops@users.noreply.github.com>
globberwops added a commit to globberwops/open-simulation-interface that referenced this issue Sep 8, 2021
@globberwops
OpenSimulationInterface#550 Require C++ 11
6f5d49e 
Signed-off-by: Martin Stump <11492152+globberwops@users.noreply.github.com>
globberwops added a commit to globberwops/open-simulation-interface that referenced this issue Sep 8, 2021
@globberwops
OpenSimulationInterface#550 Create doc target only if project is topl…
be31c99 
…evel

Signed-off-by: Martin Stump <11492152+globberwops@users.noreply.github.com>
pmai pushed a commit to globberwops/open-simulation-interface that referenced this issue May 23, 2022
@globberwops @pmai
OpenSimulationInterface#550 Provide namespaced aliases for all targets
c9b3dd4 
Signed-off-by: Martin Stump <11492152+globberwops@users.noreply.github.com>
pmai pushed a commit to globberwops/open-simulation-interface that referenced this issue May 23, 2022
@globberwops @pmai
OpenSimulationInterface#550 Rewrite the whole installation logic
120460b 
* Fix the cache variables
* Copy the headers to the appropriate location in the PROJECT_BINARY_DIR
* Rewrite the package config file template
* Create proper config, version, and target files
  using CMakePackageConfigHelpers
* Export and install namespaced targets

Signed-off-by: Martin Stump <11492152+globberwops@users.noreply.github.com>
pmai pushed a commit to globberwops/open-simulation-interface that referenced this issue May 23, 2022
@globberwops @pmai
OpenSimulationInterface#550 Remove redundant warning about Doxygen
8e435ff 
Signed-off-by: Martin Stump <11492152+globberwops@users.noreply.github.com>
pmai pushed a commit to globberwops/open-simulation-interface that referenced this issue May 23, 2022
@globberwops @pmai
OpenSimulationInterface#550 Add compile_commands.json to ignore list
c756766 
Signed-off-by: Martin Stump <11492152+globberwops@users.noreply.github.com>
pmai pushed a commit to globberwops/open-simulation-interface that referenced this issue May 23, 2022
@globberwops @pmai
OpenSimulationInterface#550 Configure osi_version.proto.in in binary dir
0907378 
Signed-off-by: Martin Stump <11492152+globberwops@users.noreply.github.com>
pmai pushed a commit to globberwops/open-simulation-interface that referenced this issue May 23, 2022
@globberwops @pmai
OpenSimulationInterface#550 Fix flatbuffers option
2f0c668 
Signed-off-by: Martin Stump <11492152+globberwops@users.noreply.github.com>
pmai pushed a commit to globberwops/open-simulation-interface that referenced this issue May 23, 2022
@globberwops @pmai
OpenSimulationInterface#550 Require C++ 11
5083adc 
Signed-off-by: Martin Stump <11492152+globberwops@users.noreply.github.com>
pmai pushed a commit to globberwops/open-simulation-interface that referenced this issue May 23, 2022
@globberwops @pmai
OpenSimulationInterface#550 Create doc target only if project is topl…
5a02aed 
…evel

Signed-off-by: Martin Stump <11492152+globberwops@users.noreply.github.com>
@pmai pmai closed this as completed in #551 May 23, 2022
pmai added a commit that referenced this issue May 23, 2022
@pmai
Merge pull request #551 from globberwops/550-cmake-build-is-missing-k…
d553d1c 
…ey-features-to-be-properly-usable-via-fetchcontent

#550 cmake build is missing key features to be properly usable via fetchcontent
adrianschultz pushed a commit to adrianschultz/open-simulation-interface that referenced this issue May 25, 2022
@globberwops @adrianschultz
OpenSimulationInterface#550 Provide namespaced aliases for all targets
2756fa5 
Signed-off-by: Martin Stump <11492152+globberwops@users.noreply.github.com>
Signed-off-by: Adrian Vernickel <adrian.vernickel@hexagon.com>
adrianschultz pushed a commit to adrianschultz/open-simulation-interface that referenced this issue May 25, 2022
@globberwops @adrianschultz
OpenSimulationInterface#550 Rewrite the whole installation logic
206c446 
* Fix the cache variables
* Copy the headers to the appropriate location in the PROJECT_BINARY_DIR
* Rewrite the package config file template
* Create proper config, version, and target files
  using CMakePackageConfigHelpers
* Export and install namespaced targets

Signed-off-by: Martin Stump <11492152+globberwops@users.noreply.github.com>
Signed-off-by: Adrian Vernickel <adrian.vernickel@hexagon.com>
adrianschultz pushed a commit to adrianschultz/open-simulation-interface that referenced this issue May 25, 2022
@globberwops @adrianschultz
OpenSimulationInterface#550 Remove redundant warning about Doxygen
6e95c7d 
Signed-off-by: Martin Stump <11492152+globberwops@users.noreply.github.com>
Signed-off-by: Adrian Vernickel <adrian.vernickel@hexagon.com>
adrianschultz pushed a commit to adrianschultz/open-simulation-interface that referenced this issue May 25, 2022
@globberwops @adrianschultz
OpenSimulationInterface#550 Add compile_commands.json to ignore list
0b31975 
Signed-off-by: Martin Stump <11492152+globberwops@users.noreply.github.com>
Signed-off-by: Adrian Vernickel <adrian.vernickel@hexagon.com>
adrianschultz pushed a commit to adrianschultz/open-simulation-interface that referenced this issue May 25, 2022
@globberwops @adrianschultz
OpenSimulationInterface#550 Configure osi_version.proto.in in binary dir
25ceacb 
Signed-off-by: Martin Stump <11492152+globberwops@users.noreply.github.com>
Signed-off-by: Adrian Vernickel <adrian.vernickel@hexagon.com>
adrianschultz pushed a commit to adrianschultz/open-simulation-interface that referenced this issue May 25, 2022
@globberwops @adrianschultz
OpenSimulationInterface#550 Fix flatbuffers option
f8f1821 
Signed-off-by: Martin Stump <11492152+globberwops@users.noreply.github.com>
Signed-off-by: Adrian Vernickel <adrian.vernickel@hexagon.com>
adrianschultz pushed a commit to adrianschultz/open-simulation-interface that referenced this issue May 25, 2022
@globberwops @adrianschultz
OpenSimulationInterface#550 Require C++ 11
c74744f 
Signed-off-by: Martin Stump <11492152+globberwops@users.noreply.github.com>
Signed-off-by: Adrian Vernickel <adrian.vernickel@hexagon.com>
adrianschultz pushed a commit to adrianschultz/open-simulation-interface that referenced this issue May 25, 2022
@globberwops @adrianschultz
OpenSimulationInterface#550 Create doc target only if project is topl…
c88f689 
…evel

Signed-off-by: Martin Stump <11492152+globberwops@users.noreply.github.com>
Signed-off-by: Adrian Vernickel <adrian.vernickel@hexagon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@globberwops