Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

620 orientation indicator for camerasensorviewconfiguration #628

Closed
wants to merge 5 commits into from
Closed

620 orientation indicator for camerasensorviewconfiguration #628

wants to merge 5 commits into from

Conversation

RIFJo
Copy link
Contributor

@RIFJo RIFJo commented Apr 28, 2022

Reference to a related issue in the repository

#620

Add a description

add new integer field "orientation" to CameraSensorViewConfiguration, and document the field
I have tested the change locally by compiling the modified .proto file to cpp and python.

Take this checklist as orientation for yourself, if this PR is ready for the Change Control Board:

  • My suggestion follows the style and contributors guidelines.
  • I have taken care about the documentation.
  • I have done the DCO signoff.
  • My changes generate no errors when passing CI tests.
  • I have successfully implemented and tested my fix/feature locally.
  • Appropriate reviewer(s) are assigned.

If you can’t check all of them, please explain why.
=> I am unsure how to perform the CI tests.

If all boxes are checked or commented and you have achieved at least one positive review, you can assign the label ReadyForCCBReview!

RIFJo added 2 commits April 28, 2022 15:21
…ration

refers to #620
adds integer field "orientation" to CameraSensorViewConfiguration
Signed-off-by: Gregor Jochmann <jochmann@rt.rif-ev.de>
refers to #620

follow style-guide for references in field comments
Signed-off-by: Gregor Jochmann <jochmann@rt.rif-ev.de>
@RIFJo
Copy link
Contributor Author

RIFJo commented Apr 28, 2022

Seems like i used the wrong name for the DCO signoff. I am now stuck trying to repair this pull request, because i have no write access to the master. Any help would be appreciated, this is my first attempt at contributing here, and my experience with GitHub is limited.

As indicated here https://github.com/OpenSimulationInterface/open-simulation-interface/pull/628/checks?check_run_id=6212187841, i have

  • checked out the pull-request locally
  • successfully run git rebase HEAD~2 --signoff
  • git push --force-with-lease origin 620-orientation-indicator-for-camerasensorviewconfiguration fails with
    error: src refspec 620-orientation-indicator-for-camerasensorviewconfiguration does not match any
    error: failed to push some refs to 'https://github.com/OpenSimulationInterface/open-simulation-interface'

As far as I understand, the branch i created is located in my personal repository https://github.com/RIFJo/open-simulation-interface

RIFJo added 3 commits April 28, 2022 16:33
…ration

refers to #620
adds integer field "orientation" to CameraSensorViewConfiguration
Signed-off-by: Gregor Jochmann <jochmann@rt.rif-ev.de>
Signed-off-by: RIFJo <jochmann@rt.rif-ev.de>
refers to #620

follow style-guide for references in field comments
Signed-off-by: Gregor Jochmann <jochmann@rt.rif-ev.de>
Signed-off-by: RIFJo <jochmann@rt.rif-ev.de>
@RIFJo
Copy link
Contributor Author

RIFJo commented Apr 28, 2022

... now the pull-request contains two signoffs (one with the correct name), but the automatted check still complains about the incorrect one.


Signed-off-by: Gregor Jochmann <jochmann@rt.rif-ev.de>
Signed-off-by: RIFJo <jochmann@rt.rif-ev.de>

I will try to redo the entire process of branching and commit a new pull request.

@RIFJo RIFJo closed this Apr 28, 2022
@RIFJo RIFJo deleted the 620-orientation-indicator-for-camerasensorviewconfiguration branch April 28, 2022 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant