Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(SensorModeling) Add orientation hint to CameraSensorViewConfigur… #629

Closed
wants to merge 89 commits into from
Closed

feat(SensorModeling) Add orientation hint to CameraSensorViewConfigur… #629

wants to merge 89 commits into from

Conversation

RIFJo
Copy link
Contributor

@RIFJo RIFJo commented Apr 28, 2022

refers to #620

Signed-off-by: RIFJo jochmann@rt.rif-ev.de

Take this checklist as orientation for yourself, if this PR is ready for the Change Control Board:

  • My suggestion follows the style and contributors guidelines.
  • I have taken care about the documentation.
  • I have done the DCO signoff.
  • My changes generate no errors when passing CI tests.
  • I have successfully implemented and tested my fix/feature locally.
  • Appropriate reviewer(s) are assigned.

If you can’t check all of them, please explain why.
If all boxes are checked or commented and you have achieved at least one positive review, you can assign the label ReadyForCCBReview!

@clemenshabedank
Copy link
Contributor

09.05.2022: @kmeids can you please invite @RIFJo and discuss this in the sensor model group?

RIFJo and others added 29 commits December 15, 2022 14:23
@RIFJo
feat(SensorModeling) Add orientation hint to CameraSensorViewConfigur…
19f47ec 
…ation

refers to #620

Signed-off-by: RIFJo <jochmann@rt.rif-ev.de>
@LukasElster @RIFJo
Added coordinate transformation to documentation
9d1b098 
Signed-off-by: @lukas.elster <lukas.elster@tu-darmstadt.de>
Signed-off-by: RIFJo <jochmann@rt.rif-ev.de>
@LukasElster @RIFJo
Bugfix in citation
9b48ecf 
Signed-off-by: @lukas.elster <lukas.elster@tu-darmstadt.de>
Signed-off-by: RIFJo <jochmann@rt.rif-ev.de>
@PhRosenberger @RIFJo
Removing the note on OSI using singular for plural everywhere
6966e56 
Signed-off-by: PhRosenberger <philipp.rosenberger@tu-darmstadt.de>
Signed-off-by: RIFJo <jochmann@rt.rif-ev.de>
@PhRosenberger @RIFJo
Adding the note on OSI using singular for plural in general docu
9b1385b 
Signed-off-by: PhRosenberger <philipp.rosenberger@tu-darmstadt.de>
Signed-off-by: RIFJo <jochmann@rt.rif-ev.de>
@RIFJo
Added wind, cloud state and sun to environment
7f9b0d6 
Signed-off-by: Markus Waldmann <Markus.Waldmann@stud.hs-kempten.de>
Signed-off-by: RIFJo <jochmann@rt.rif-ev.de>
@RIFJo
Rework wind, cloud, and sun definitions in environment
6f0354a 
- Move cloud state enums into CloudState message

  The enum has been changed to CloudStateLevel and moved into a more
  open meaning message of CloudState. This can easily be expanded in the
  future with more detailed information.

- Generalize definition text of the wind

  The message within the description was too specific, if in the future
  updates will probably have more than only the wind speed and direction
  in it.

- Definition text changed Sun and Wind

  The definition within the Sun and Wind messages were indicating that
  data must originate from an OpenSCENARIO file.

- Definition text rules and unit Sun changed

  The definition within the Sun message was not divided into units,
  rules and description

- Fixes to field numbering, nesting, etc. to align with interface rules

Signed-off-by: Markus Waldmann <Markus.Waldmann@stud.hs-kempten.de>
Signed-off-by: RIFJo <jochmann@rt.rif-ev.de>
@RIFJo
Rework cloud, sun, and wind in environment
66e390b 
- Remove LEVEL_NO_SKY in CloudStateLevel

  There will be no need for now for this state, if no sky is needed, use
  LEVEL_OTHER.

- Describe rules within description

  With rules there is no greater than pi possible. Therefore, moved the
  rules to the description.

- Change wind description

  Changed the range to -pi to +pi like in common.proto for Oreintation3d
  messages. Added a note for minding the conversation from openSCENARIO.

Signed-off-by: Markus Waldmann <Markus.Waldmann@stud.hs-kempten.de>
Signed-off-by: RIFJo <jochmann@rt.rif-ev.de>
@RIFJo
Further rework of environment additions sun, cloud
e87f231 
- Move TimeOfDay message back to avoid confusion

- Change the message name Clouds to CloudLayer

- Change the SUN angular range

- Wind direction is now origin not target

Signed-off-by: Markus Waldmann <Markus.Waldmann@stud.hs-kempten.de>

Co-authored-by: Kmeid <kmeid.saad@ansys.com>
Signed-off-by: RIFJo <jochmann@rt.rif-ev.de>
@RIFJo
Changed naming in CloudLayer, added Sky Obscured
c73c858 
Renamed ENUMS to LEVEL0-8, added LEVEL_SKY_OBSCURED for situations where the sky is not perceivable, Visual Reference in the comments added

Signed-off-by: Markus Waldmann <Markus.Waldmann@stud.hs-kempten.de>
Signed-off-by: RIFJo <jochmann@rt.rif-ev.de>
@RIFJo
Changed descriptions in CloudLayer
1a0f459 
Signed-off-by: Markus Waldmann <Markus.Waldmann@stud.hs-kempten.de>
Signed-off-by: RIFJo <jochmann@rt.rif-ev.de>
@pmai @RIFJo
Apply suggestions from code review for environment additions
94ff3cb 
Signed-off-by: Pierre R. Mai <pmai@pmsf.de>

Co-authored-by: Kmeid <kmeid.saad@ansys.com>
Signed-off-by: RIFJo <jochmann@rt.rif-ev.de>
@RIFJo
Changed descriptions for Sun and Wind
c046907 
Harmonisation group output: Rework of range and counting methods for azimuth, elevation and wind direction.

Signed-off-by: Markus Waldmann <Markus.Waldmann@stud.hs-kempten.de>
Signed-off-by: RIFJo <jochmann@rt.rif-ev.de>
@RIFJo
Changed cloud, wind descriptions to fulfill comments
b6dbae7 
Changed Definition -> Description several times
Changed description texts
Changed Ranges of wind direction
Changed ENUM cloud layer
ENUM CloudLayerLevel -> FractionalCloudCover
Added new reference
changed naming and description text

Signed-off-by: Markus Waldmann <Markus.Waldmann@stud.hs-kempten.de>

Changed ENUM FractionalCloudCover

Signed-off-by: Markus Waldmann <Markus.Waldmann@stud.hs-kempten.de>
Signed-off-by: RIFJo <jochmann@rt.rif-ev.de>
@RIFJo
Changed description of cloud cover
ac69645 
changed the references

Signed-off-by: Markus Waldmann <Markus.Waldmann@stud.hs-kempten.de>
Signed-off-by: RIFJo <jochmann@rt.rif-ev.de>
@thomassedlmayer @RIFJo
Fix minor doc formatting issues
4019219 
Signed-off-by: thomassedlmayer <thomas.sedlmayer@tum.de>
Signed-off-by: RIFJo <jochmann@rt.rif-ev.de>
@thomassedlmayer @RIFJo
Change sun elevation description
826216d 
Signed-off-by: thomassedlmayer <tsedlmayer@pmsfit.de>
Signed-off-by: RIFJo <jochmann@rt.rif-ev.de>
@thomassedlmayer @RIFJo
Add description to unix timestamp
0d39aac 
Signed-off-by: thomassedlmayer <tsedlmayer@pmsfit.de>
Signed-off-by: RIFJo <jochmann@rt.rif-ev.de>
@thomassedlmayer @RIFJo
Specify observation point for sun
2094b36 
Signed-off-by: thomassedlmayer <tsedlmayer@pmsfit.de>
Signed-off-by: RIFJo <jochmann@rt.rif-ev.de>
@RIFJo
Introduce backchannel message TrafficCommandUpdate
cea8b62 
Signed-off-by: Habedank Clemens <qxs2704@europe.bmw.corp>
Signed-off-by: RIFJo <jochmann@rt.rif-ev.de>
@RIFJo
Refactor and clarify semantics of TrafficCommandUpdate
4e3344e 
Signed-off-by: Habedank Clemens <qxs2704@europe.bmw.corp>
Signed-off-by: RIFJo <jochmann@rt.rif-ev.de>
@tpajenkamp-dspace @RIFJo
Fix protobuf message tags in TrafficCommandUpdate
8e5127b 
Signed-off-by: Thomas Pajenkamp <tpajenkamp@dspace.de>
Signed-off-by: RIFJo <jochmann@rt.rif-ev.de>
@clemenshabedank @caspar-ai @RIFJo
Apply suggestions from code review
6ba8bf7 
Minor spelling fixes

Co-authored-by: caspar-ai <caspar.dehaes@five.ai>
Signed-off-by: clemenshabedank <clemens.habedank@partner.bmw.de>
Signed-off-by: RIFJo <jochmann@rt.rif-ev.de>
@clemenshabedank @RIFJo
Apply suggestions from code review
0b0601a 
Changes that appear uncontroversial.

Signed-off-by: clemenshabedank <clemens.habedank@partner.bmw.de>
Signed-off-by: RIFJo <jochmann@rt.rif-ev.de>
@RIFJo
Incorporate CCB feedback on dismissed actions semantics
2cf4ac9 
Signed-off-by: Habedank Clemens <qxs2704@europe.bmw.corp>
Signed-off-by: RIFJo <jochmann@rt.rif-ev.de>
@RIFJo
Delete sentence about usage recommendation due to normativity issues
9b3da61 
Signed-off-by: Habedank Clemens <qxs2704@europe.bmw.corp>
Signed-off-by: RIFJo <jochmann@rt.rif-ev.de>
@tbleher @RIFJo
Correct documentation of Identifier of ReferenceLine
a894cef 
Signed-off-by: Thomas Bleher <thomas.tb.bleher@bmw.de>
Signed-off-by: RIFJo <jochmann@rt.rif-ev.de>
@ThomasNaderBMW @RIFJo
Introducing Operating States
f8e50da 
The operating state of the vehicle.

Signed-off-by: Thomas Nader <Thomas.Nader@bmw.de>
Signed-off-by: RIFJo <jochmann@rt.rif-ev.de>
@ThomasNaderBMW @RIFJo
State instead of status
491447b 
State instead of status.

Signed-off-by: Thomas Nader <Thomas.Nader@bmw.de>
Signed-off-by: RIFJo <jochmann@rt.rif-ev.de>
philipwindecker and others added 28 commits December 15, 2022 14:23
@philipwindecker @RIFJo
Added tab anchors
b8d27ad 
Signed-off-by: Philip Windecker <philip.windecker@avenyr.de>
Signed-off-by: RIFJo <jochmann@rt.rif-ev.de>
@philipwindecker @RIFJo
Fixed minor bugs and updated links to
ea61833 
interface spec

Signed-off-by: Philip Windecker <philip.windecker@avenyr.de>
Signed-off-by: RIFJo <jochmann@rt.rif-ev.de>
@philipwindecker @RIFJo
Updated feedback button behavior
d033056 
Signed-off-by: Philip Windecker <philip.windecker@avenyr.de>
Signed-off-by: RIFJo <jochmann@rt.rif-ev.de>
@philipwindecker @RIFJo
Updated README
f5478bd 
Signed-off-by: Philip Windecker <philip.windecker@avenyr.de>
Signed-off-by: RIFJo <jochmann@rt.rif-ev.de>
@philipwindecker @RIFJo
Antora tagging
bd54b95 
Signed-off-by: Philip Windecker <philip.windecker@avenyr.de>
Signed-off-by: RIFJo <jochmann@rt.rif-ev.de>
@philipwindecker @RIFJo
Unified versioning for repos
904a3c8 
Signed-off-by: Philip Windecker <philip.windecker@avenyr.de>
Signed-off-by: RIFJo <jochmann@rt.rif-ev.de>
@philipwindecker @RIFJo
Updated image link for asciidoc
7ca09d3 
Signed-off-by: Philip Windecker <philip.windecker@avenyr.de>
Signed-off-by: RIFJo <jochmann@rt.rif-ev.de>
@philipwindecker @RIFJo
Updated pull request template
912a193 
Signed-off-by: Philip Windecker <philip.windecker@avenyr.de>
Signed-off-by: RIFJo <jochmann@rt.rif-ev.de>
@philipwindecker @RIFJo
Fix path to asciidoc-resources
940c60c 
Signed-off-by: Philip Windecker <philip.windecker@avenyr.de>
Signed-off-by: RIFJo <jochmann@rt.rif-ev.de>
@philipwindecker @RIFJo
Added one more missing step
290e59b 
Signed-off-by: Philip Windecker <philip.windecker@avenyr.de>
Signed-off-by: RIFJo <jochmann@rt.rif-ev.de>
@philipwindecker @RIFJo
Build/master branch naming (#672)
8d6ab57 
Change version naming for master branch, update Ubuntu image, and add Antora generator trigger.

Signed-off-by: Philip Windecker <philip.windecker@avenyr.de>
Signed-off-by: Philip Windecker <95633467+philipwindecker@users.noreply.github.com>
Signed-off-by: Pierre R. Mai <pmai@pmsf.de>
Signed-off-by: RIFJo <jochmann@rt.rif-ev.de>
@pmai @RIFJo
Never trigger antora builds for PRs from forks (#686)
56b63ea 
Since no secrets will be available for security reasons, do not try to
trigger antora builds when those secrets are not available.

Signed-off-by: Pierre R. Mai <pmai@pmsf.de>
Signed-off-by: RIFJo <jochmann@rt.rif-ev.de>
@thomassedlmayer @RIFJo
Fix traffic sign variability attribute description
48217fb 
Aligns variability attribute description with existing enum description

Signed-off-by: Thomas Sedlmayer <tsedlmayer@pmsfit.de>
Signed-off-by: RIFJo <jochmann@rt.rif-ev.de>
@PhRosenberger @RIFJo
Fixing title of Fig. 10 with coordinate systems
0c7c52c 
Signed-off-by: Philipp Rosenberger <philipp.rosenberger@persival.de>
Signed-off-by: RIFJo <jochmann@rt.rif-ev.de>
@thomassedlmayer @RIFJo
Add new traffic sign variability types
a7c2da7 
- Clarify definition of old types to differentiate from new types
- Add new types VARIABLE_MOVABLE and VARIABLE_MUTABLE

Signed-off-by: Thomas Sedlmayer <tsedlmayer@pmsfit.de>
Signed-off-by: RIFJo <jochmann@rt.rif-ev.de>
@thomassedlmayer @RIFJo
Add new variability type and update comments
7a36962 
Signed-off-by: Thomas Sedlmayer <tsedlmayer@pmsfit.de>
Signed-off-by: RIFJo <jochmann@rt.rif-ev.de>
@schmidtlorenz @RIFJo
Add classification for stand-up scooters
79c63f8 
feat(vehicle classifications): add classification for stand-up scooters, motivated by possible NCAP target type

refers to issue #673

Signed-off-by: schmidtlorenz <107173594+schmidtlorenz@users.noreply.github.com>
Signed-off-by: Pierre R. Mai <pmai@pmsf.de>
Signed-off-by: RIFJo <jochmann@rt.rif-ev.de>
@pmai @RIFJo
Fix whitespace issues
e2153b5 
Signed-off-by: Pierre R. Mai <pmai@pmsf.de>
Signed-off-by: RIFJo <jochmann@rt.rif-ev.de>
@ReinhardBiegelIntech @RIFJo
Adapt ReferenceLine ST definition to avoid tranformation ambiguity an…
143c883 
…d discontinuities

Also-by: Weiss David <david.weiss@in-tech.com>
Signed-off-by: Reinhard Biegel <reinhard.biegel@in-tech.com>
Signed-off-by: RIFJo <jochmann@rt.rif-ev.de>
@ReinhardBiegelIntech @RIFJo
Clarify T coordinate definition in case of missing T axes intersection
505bb65 
Signed-off-by: Reinhard Biegel <reinhard.biegel@in-tech.com>
Signed-off-by: RIFJo <jochmann@rt.rif-ev.de>
@ReinhardBiegelIntech @RIFJo
Re-add formatting markers
34c77e7 
Signed-off-by: Reinhard Biegel <reinhard.biegel@in-tech.com>
Signed-off-by: RIFJo <jochmann@rt.rif-ev.de>
@ReinhardBiegelIntech @RIFJo
Clarify contraints on T axis
9d33f5a 
Also-by: Weiss David <david.weiss@in-tech.com>
Signed-off-by: Reinhard Biegel <reinhard.biegel@in-tech.com>
Signed-off-by: RIFJo <jochmann@rt.rif-ev.de>
@weissdavid @RIFJo
Introduce reference line type enum
993feaf 
The type of a reference line will determine how S and T coordinates have
to be calculated. Type POLYLINE is equal to the previous ST definition.
A new type POLYLINE_WITH_T_AXIS is introduced for improved ST handling.

Signed-off-by: Weiss David <david.weiss@in-tech.com>
Signed-off-by: Reinhard Biegel <reinhard.biegel@in-tech.com>
Signed-off-by: RIFJo <jochmann@rt.rif-ev.de>
@ReinhardBiegelIntech @RIFJo
Missing enum member TYPE prefix
0fa0152 
Signed-off-by: Reinhard Biegel <reinhard.biegel@in-tech.com>
Signed-off-by: RIFJo <jochmann@rt.rif-ev.de>
@ReinhardBiegelIntech @RIFJo
Add ReferenceLine Type documantation
67b0cf8 
Signed-off-by: Reinhard Biegel <reinhard.biegel@in-tech.com>
Signed-off-by: RIFJo <jochmann@rt.rif-ev.de>
@ReinhardBiegelIntech @RIFJo
New ST calculation method cleanups
46eb055 
Also-by: Weiss David <david.weiss@in-tech.com>
Signed-off-by: Reinhard Biegel <reinhard.biegel@in-tech.com>
Signed-off-by: RIFJo <jochmann@rt.rif-ev.de>
@ReinhardBiegelIntech @RIFJo
Note on ST coordinates to avoid confusion with other standards
365a2c5 
Also-by: Weiss David <david.weiss@in-tech.com>
Signed-off-by: Reinhard Biegel <reinhard.biegel@in-tech.com>
Signed-off-by: RIFJo <jochmann@rt.rif-ev.de>
@RIFJo
Update after discussion in workgroup
a0e6c9a 
use enum instead of EXIF tag.
only provide mirroring, no rotation options

Signed-off-by: RIFJo <jochmann@rt.rif-ev.de>
@RIFJo
Copy link
Contributor Author

RIFJo commented Dec 15, 2022

Confused with the GitHub workflow. I will prepare a new pull request with just my changes

@RIFJo RIFJo closed this Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.