Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Draft for discussion: Added new elements to DataQualifier #659

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Draft for discussion: Added new elements to DataQualifier #659

wants to merge 4 commits into from

Conversation

FlorianMueller87
Copy link
Contributor

@FlorianMueller87 FlorianMueller87 commented Aug 9, 2022 •
edited
Loading

Added new elements to DataQualifier (REDUCE_INVIEW_AND_PERFORMANCE, TEST_MODE, INVALID, REDUCED_PERFORMANCE)

#### Reference to a related issue in the repository

Issue: #646

Add a description

ASAM OSI and ISO 23150 or AUTOSAR ADI have a common history. Unfortunately, the inner structure, the naming and the definitions of the standards are differentiated from each other. This makes the work of developers unnecessary complicated for mostly no technical reasons. All sides should strive to reduce inequality.

ASAM OSI need the entries for osi_sensordata - DetectedEntityHeader – DataQualifier to be compatible with AUTOSAR ADI DataQualifier.

Take this checklist as orientation for yourself, if this PR is ready for the Change Control Board:

  • My suggestion follows the style and contributors guidelines.
  • I have taken care about the documentation.
  • I have done the DCO signoff.
  • My changes generate no errors when passing CI tests.
  • I have successfully implemented and tested my fix/feature locally.
  • Appropriate reviewer(s) are assigned.

Additional context

ISO23150:2021 A.1.9 Data qualifier
@ThomasNaderBMW @jdsika @schmidtlorenz

@FlorianMueller87
Added new elements to DataQualifier (REDUCE_INVIEW_AND_PERFORMANCE, T…
c76a2c9 
…EST_MODE, INVALID, REDUCED_PERFORMANCE)

Issue: OpenSimulationInterface#646
Signed-off-by: FlorianMueller87 <florian.b.mueller@gmx.de>
@FlorianMueller87 FlorianMueller87 force-pushed the feature/add_elements_to_DataQualifier branch from c7351c8 to c76a2c9 Compare August 12, 2022 07:10
@jdsika jdsika added the Harmonisation The Group in the ASAM development project working on harmonisation with other standards. label Oct 17, 2022
jdsika
jdsika reviewed Oct 17, 2022
View reviewed changes
osi_sensordata.proto Outdated

// Reported data are from the sensor in a restricted view and performance.
//
DATA_QUALIFIER_REDUCE_INVIEW_AND_PERFORMANCE = 7;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

REDUCED_VIEW???

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

has COVERAGE from ISO been renamed to VIEW?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ISO and ADI both uses REDUCE

Yes, the name has changed, I will ask why.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ViEW is also a mistake. I will change it to COVERAGE.

@jdsika
Copy link
Contributor

jdsika commented Oct 17, 2022

@FlorianMueller87 please add the ADI table here to discuss the needed changes as the proposed changes here are not the ones from the released ISO

@jdsika jdsika linked an issue Oct 17, 2022 that may be closed by this pull request
ISO23150 compliance: Adding new states to and Change naming [SensorData - DetectedEntityHeader - DataQualifier] #646
Open
@FlorianMueller87
Copy link
Contributor Author

kNormal 0x00 Information can be used without restriction.
kNotAvailable 0x01 Information from the senor is not available.
kReduceInCoverage 0x02 Reported data are from the sensor in a restricted view.
kReduceInPerformance 0x03 Reported data are from the sensor in a restricted performance.
kReduceInViewAndPerformance 0x04 Reported data are from the sensor in a restricted view and performance.
kTestMode 0x05 Reported data are from the sensor in a test mode.
kInvalid 0x06 Mesaurement cycle was invalid and no valid objects will be reported.
kUnknown 0x07 Data quality is unknown.

@thempen
Copy link
Contributor

thempen commented Dec 7, 2022

Comment from WG Harmonization:
We need further information about the provided list. Please describe, in which situation the various cases will be used.
Please describe the "view" and "coverage", shouldn't there be a uniform wording?

@ClemensLinnhoff ClemensLinnhoff added the AUTOSAR ADI Topics connected to AUTOSAR ADI definition. label Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdsika jdsika jdsika left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
AUTOSAR ADI Topics connected to AUTOSAR ADI definition. Harmonisation The Group in the ASAM development project working on harmonisation with other standards.
Projects
None yet
Milestone
No milestone
4 participants
@FlorianMueller87 @jdsika @thempen @ClemensLinnhoff