Dark mode: Dropdown variant #2323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louismaximepiton
added
the
color mode
✅ Deploy Preview for boosted ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
julien-deramond
force-pushed
the
main-jd-dark-mode
branch
from
8ae7abe to
670f453
Compare
louismaximepiton
force-pushed
the
main-lmp-dropdown-variant
branch
2 times, most recently
from
ea24dbe to
12178c8
Compare
julien-deramond
force-pushed
the
main-jd-dark-mode
branch
from
bbf1afd to
fc169fa
Compare
julien-deramond
changed the title
julien-deramond
force-pushed
the
main-jd-dark-mode
branch
3 times, most recently
from
03af5c3 to
f49a3ee
Compare
julien-deramond
force-pushed
the
main-lmp-dropdown-variant
branch
from
12178c8 to
49bfcbe
Compare
julien-deramond
force-pushed
the
main-jd-dark-mode
branch
2 times, most recently
from
35328ca to
f0b8a1e
Compare
julien-deramond
force-pushed
the
main-lmp-dropdown-variant
branch
from
49bfcbe to
24c5d9b
Compare
julien-deramond
force-pushed
the
main-jd-dark-mode
branch
from
bc73b51 to
7fa6a42
Compare
julien-deramond
force-pushed
the
main-lmp-dropdown-variant
branch
2 times, most recently
from
0ea17e5 to
6b60f7a
Compare
This comment was marked as resolved.
This comment was marked as resolved.
julien-deramond
force-pushed
the
main-jd-dark-mode
branch
from
6b93b32 to
af61298
Compare
julien-deramond
force-pushed
the
main-lmp-dropdown-variant
branch
from
22fdb25 to
c44c95b
Compare
julien-deramond
force-pushed
the
main-jd-dark-mode
branch
from
af61298 to
85428a8
Compare
julien-deramond
force-pushed
the
main-lmp-dropdown-variant
branch
from
c44c95b to
f48c800
Compare
julien-deramond
force-pushed
the
main-jd-dark-mode
branch
from
85428a8 to
5326d71
Compare
julien-deramond
force-pushed
the
main-lmp-dropdown-variant
branch
from
f48c800 to
57f1eed
Compare
Update dropdown doc Update dark-mode page Fix split dropdown issue + design + Add dark mode checks
julien-deramond
force-pushed
the
main-lmp-dropdown-variant
branch
from
4809a33 to
5d65a1a
Compare
julien-deramond
approved these changes
Nov 13, 2023
Merged
julien-deramond
added a commit
that referenced
this pull request
Nov 15, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond
added a commit
that referenced
this pull request
Nov 27, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond
added a commit
that referenced
this pull request
Nov 27, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond
added a commit
that referenced
this pull request
Nov 27, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond
added a commit
that referenced
this pull request
Nov 29, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond
added a commit
that referenced
this pull request
Nov 30, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond
added a commit
that referenced
this pull request
Dec 1, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond
added a commit
that referenced
this pull request
Dec 4, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond
added a commit
that referenced
this pull request
Dec 8, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond
added a commit
that referenced
this pull request
Dec 15, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond
added a commit
that referenced
this pull request
Dec 18, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond
added a commit
that referenced
this pull request
Dec 21, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond
added a commit
that referenced
this pull request
Dec 26, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond
added a commit
that referenced
this pull request
Dec 27, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond
added a commit
that referenced
this pull request
Jan 2, 2024
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Dropped
:not(.toggle-plit-dropdown)rule inside.dropdown-toggleand introduce it as.btn-dropdownSearched for every
.dropdown-toggleand related.btn-secondaryand decide whether it's a.toggle-split-dropdown, it should change to the new.btn-dropdownor let it as Bootstrap:CHANGELOG.md: nothing to do.js/src/scrollspy.js: nothing to do.js/src/tab.js: nothing to do.js/tests/unit/dropdown.spec.js: nothing to do.js/tests/unit/tab.spec.js: nothing to do.js/tests/visual/dropdown.html:.btn-secondary.dropdown-toggle->.btn-dropdown.dropdown-toggle.dropdown-toggle-splitwhere needed to have the good rendering.js/tests/visual/scrollspy.html: nothing to do.scss/_button-group.scss: nothing to doscss/_dropdown.scss: nothing to doscss/_input-group.scss: nothing to doscss/_navbar.scss: nothing to dosite/content/docs/5.3/dark-mode.md:.btn-secondary.dropdown-toggleby.btn-dropdown.dropdown-togglein the corresponding examples in #buttons.btn-secondary.dropdown-toggleby.btn-dropdown.dropdown-togglein the corresponding examples in #dropdowns.btn-secondaryby.btn-outline-secondaryin the corresponding examples in #input-groupsite/content/docs/5.3/migration.md: nothing to do.site/content/docs/5.3/components/button-group.md: Changed.btn-secondaryto.btn-outline-secondaryin the doc.site/content/docs/5.3/components/dropdowns.md: Replaced all the.btn-secondary.dropdown-toggleby.btn-dropdown.dropdown-togglein the corresponding examples.site/content/docs/5.3/components/navbar.md: nothing to do.site/content/docs/5.3/components/navs-tabs.md: nothing to do.site/content/docs/5.3/components/offcanvas.md: Replaced all the.btn-secondary.dropdown-toggleby.btn-dropdown.dropdown-togglein the corresponding examples.site/content/docs/5.3/components/scrollspy.md: nothing to do.site/content/docs/5.3/customize/color-modes.md:.btn-secondary.dropdown-toggleby.btn-dropdown.dropdown-togglein the corresponding examples.site/assets/scss/_content.scsssite/content/docs/5.3/customize/options.md: nothing to do.site/content/docs/5.3/forms/input-group.md: Replaced all the.btn-secondary.dropdown-toggleby.btn-dropdown.dropdown-togglein the corresponding examples.site/layout/_default/examples.html: nothing to do.site/layout/partials/docs-navbar.html: nothing to do.site/layout/partials/docs-versions.html: nothing to do.site/layout/partials/home/plugins.html:.btn-primarywas let.Links
TODO
<details><summary>+ Design callouts.dropdown-toggle.dropdown-toggle-splitMisc
.dropdownisn't used at all ❓