Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dark mode: Tooltips #2352

Merged
merged 2 commits into from
Nov 3, 2023
Merged

Dark mode: Tooltips #2352

merged 2 commits into from
Nov 3, 2023

Conversation

louismaximepiton
Copy link
Member

@louismaximepiton louismaximepiton commented Nov 3, 2023 •
edited by julien-deramond
Loading

@louismaximepiton louismaximepiton added the color mode Temporary label to highlight color mode issues label Nov 3, 2023
@netlify Netlify
Copy link

netlify bot commented Nov 3, 2023 •
edited
Loading

✅ Deploy Preview for boosted ready!

Name Link
🔨 Latest commit f9feb57
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/6544da4d0964000008aafe66
😎 Deploy Preview https://deploy-preview-2352--boosted.netlify.app/docs/5.3/dark-mode
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@julien-deramond julien-deramond self-requested a review November 3, 2023 11:34
julien-deramond
julien-deramond approved these changes Nov 3, 2023
View reviewed changes
Copy link
Contributor

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Arrow border color rendering is not great in dark mode. The value is correct but it looks like it's grayish... IDK if we can find a workaround for that.

@julien-deramond julien-deramond merged commit 7a78e4b into main-jd-dark-mode Nov 3, 2023
@julien-deramond julien-deramond deleted the main-lmp-tooltip-dark branch November 3, 2023 11:35
@julien-deramond julien-deramond mentioned this pull request Nov 3, 2023
Merged
julien-deramond added a commit that referenced this pull request Nov 3, 2023
@louismaximepiton @julien-deramond
Dark mode: Tooltips (#2352)
2a05d1b 
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Nov 6, 2023
@louismaximepiton @julien-deramond
Dark mode: Tooltips (#2352)
682557f 
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Nov 7, 2023
@louismaximepiton @julien-deramond
Dark mode: Tooltips (#2352)
14d6216 
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Nov 8, 2023
@louismaximepiton @julien-deramond
Dark mode: Tooltips (#2352)
9f3c839 
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Nov 10, 2023
@louismaximepiton @julien-deramond
Dark mode: Tooltips (#2352)
7987ae4 
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Nov 13, 2023
@louismaximepiton @julien-deramond
Dark mode: Tooltips (#2352)
b3409dc 
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Nov 15, 2023
@louismaximepiton @julien-deramond
Dark mode: Tooltips (#2352)
a4628f4 
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Nov 27, 2023
@louismaximepiton @julien-deramond
Dark mode: Tooltips (#2352)
0831ab3 
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Nov 27, 2023
@louismaximepiton @julien-deramond
Dark mode: Tooltips (#2352)
e3d338c 
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Nov 27, 2023
@louismaximepiton @julien-deramond
Dark mode: Tooltips (#2352)
46ea4a6 
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Nov 29, 2023
@louismaximepiton @julien-deramond
Dark mode: Tooltips (#2352)
15b4a23 
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Nov 30, 2023
@louismaximepiton @julien-deramond
Dark mode: Tooltips (#2352)
8676988 
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Dec 1, 2023
@louismaximepiton @julien-deramond
Dark mode: Tooltips (#2352)
c9ec408 
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Dec 4, 2023
@louismaximepiton @julien-deramond
Dark mode: Tooltips (#2352)
4846f3b 
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Dec 8, 2023
@louismaximepiton @julien-deramond
Dark mode: Tooltips (#2352)
d6617b0 
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Dec 15, 2023
@louismaximepiton @julien-deramond
Dark mode: Tooltips (#2352)
3af40ac 
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Dec 18, 2023
@louismaximepiton @julien-deramond
Dark mode: Tooltips (#2352)
c295fce 
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Dec 21, 2023
@louismaximepiton @julien-deramond
Dark mode: Tooltips (#2352)
86bc344 
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Dec 26, 2023
@louismaximepiton @julien-deramond
Dark mode: Tooltips (#2352)
83f673c 
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Dec 27, 2023
@louismaximepiton @julien-deramond
Dark mode: Tooltips (#2352)
21798c2 
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Jan 2, 2024
@louismaximepiton @julien-deramond
Dark mode: Tooltips (#2352)
d4a9de3 
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julien-deramond julien-deramond julien-deramond approved these changes

Assignees
No one assigned
Labels
color mode Temporary label to highlight color mode issues
Projects
🟣 [Orange-Boosted-Bootstrap] PRs Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@louismaximepiton @julien-deramond