Dark mode: revert some changes linked to main temporary .text-* utilities usage before dark mode
#2414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julien-deramond
added
the
color mode
✅ Deploy Preview for boosted ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
julien-deramond
changed the title
.text-* utilities usage before dark mode
louismaximepiton
requested changes
Dec 14, 2023
julien-deramond
changed the title
.text-* utilities usage before dark modemain temporary .text-* utilities usage before dark mode
julien-deramond
force-pushed
the
main-jd-dark-mode
branch
from
db6a8fc to
11ea5fa
Compare
julien-deramond
force-pushed
the
main-jd-dark-mode-revert-some-color-changes
branch
from
d7576d4 to
39e223e
Compare
julien-deramond
force-pushed
the
main-jd-dark-mode
branch
from
cd206e8 to
40ca82c
Compare
julien-deramond
force-pushed
the
main-jd-dark-mode-revert-some-color-changes
branch
2 times, most recently
from
3774772 to
b382267
Compare
julien-deramond
force-pushed
the
main-jd-dark-mode-revert-some-color-changes
branch
from
b382267 to
948a647
Compare
julien-deramond
deleted the
main-jd-dark-mode-revert-some-color-changes
branch
julien-deramond
added a commit
that referenced
this pull request
Dec 21, 2023
…tilities usage before dark mode (#2414)
julien-deramond
added a commit
that referenced
this pull request
Dec 26, 2023
…tilities usage before dark mode (#2414)
julien-deramond
added a commit
that referenced
this pull request
Dec 27, 2023
…tilities usage before dark mode (#2414)
julien-deramond
added a commit
that referenced
this pull request
Jan 2, 2024
…tilities usage before dark mode (#2414)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR tackles the following sub-task identified in #2140:
This PR contains the only elements I've found to modify that were extra temporary elements coming from this PR. The dark mode implementation already took care of the majority of them by removing mostly extra
.text-*classes.Live previews