-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dark mode: Dropdown fix design #2417
Merged
julien-deramond
merged 1 commit into
main-jd-dark-mode
from
main-lmp-dark-dropdown-fix-design
Dec 19, 2023
Merged
Dark mode: Dropdown fix design #2417
julien-deramond
merged 1 commit into
main-jd-dark-mode
from
main-lmp-dark-dropdown-fix-design
Dec 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for boosted ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
db6a8fc
to
11ea5fa
Compare
e38bf20
to
658605f
Compare
cd206e8
to
40ca82c
Compare
658605f
to
538d307
Compare
julien-deramond
approved these changes
Dec 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Passed the design review. LGTM in terms of code.
The active visible focus rendering is better this way. We should do the same thing for list groups IMO.
julien-deramond
pushed a commit
that referenced
this pull request
Dec 21, 2023
julien-deramond
pushed a commit
that referenced
this pull request
Dec 26, 2023
julien-deramond
pushed a commit
that referenced
this pull request
Dec 27, 2023
julien-deramond
pushed a commit
that referenced
this pull request
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Following the desin updates for the dark mode.
Also remove the focus state of the active state that is no longer relevant.
Live previews