-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: [OUDS] Small adjustments on buttons doc #2904
base: ouds/main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for boosted ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
> .btn-group { | ||
margin: .25rem .125rem; | ||
.btn, | ||
.btn-group { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find this change dangerous, because we could have component containing button, like inline alert, and we don't want to change the margin in this case. The direct child selector should be kept I think (but it won't work for button in div or other container :/
Maybe the most reliable way to do it is to add a parent class for this style and to add this class in the button examples ?
Note: Please transform
- [ ]
into- (NA)
in the description when things are not applicableRelated issues
Description
fill="currentColor"
on<svg>
s since it is already set into the sprite file, and mention it in the docwidth="1rem" height="1rem"
on<svg>
s since it is already done by styling, and remove it in the docMotivation & Context
Small fixes to do regarding what has been done on other documentation pages, and forgotten elements.
Types of change
Live previews