Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: [OUDS] Small adjustments on buttons doc #2904

Draft
wants to merge 10 commits into
base: ouds/main
Choose a base branch
from

Conversation

hannahiss
Copy link
Member

@hannahiss hannahiss commented Mar 20, 2025

Note: Please transform - [ ] into - (NA) in the description when things are not applicable

Related issues

Description

  • add more margin around buttons in doc to be compliant with design documentation, in particular between buttons side to side
  • add missing dot at the end of warning callout like in "Links"
  • remove useless fill="currentColor" on <svg>s since it is already set into the sprite file, and mention it in the doc
  • remove useless width="1rem" height="1rem" on <svg>s since it is already done by styling, and remove it in the doc
  • remove CSS/Sass variables at the end
  • fix "JavaScript" typo in the loading button example

Motivation & Context

Small fixes to do regarding what has been done on other documentation pages, and forgotten elements.

Types of change

  • Bug fix (non-breaking which fixes an issue)

Live previews

Copy link

netlify bot commented Mar 20, 2025

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit ba77ab4
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/67dd364552ed470008206141
😎 Deploy Preview https://deploy-preview-2904--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

> .btn-group {
margin: .25rem .125rem;
.btn,
.btn-group {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find this change dangerous, because we could have component containing button, like inline alert, and we don't want to change the margin in this case. The direct child selector should be kept I think (but it won't work for button in div or other container :/

Maybe the most reliable way to do it is to add a parent class for this style and to add this class in the button examples ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants