Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fullscreen in non-supported browsers #32

Closed
OscarGodson opened this issue Feb 25, 2012 · 7 comments
Closed

Fullscreen in non-supported browsers #32

OscarGodson opened this issue Feb 25, 2012 · 7 comments

Comments

@OscarGodson
Copy link
Owner

While not entirely important, it'd be great to still support fullscreen by doing "fullwindow" rather true fullscreen. i.e. the editor would fill the window and act just as if it would in fullscreen in supported browsers.

@OscarGodson
Copy link
Owner Author

This now doesn't only include IE, but Firefox too see #22 which means this is being bumped to the public alpha milestone

@OscarGodson
Copy link
Owner Author

Also we'll wanna see if we can trigger IE's fullscreen programmaticall. Users can access fullscreen via F11, so if possible we'd do the same thing we'd do for other browsers like Firefox by making the <iframe> 100% width and height of the window, but then trigger F11, if possible. If not we should probably show a note to IE users that they can make it more fullscreen by pressing F11

Also, we'll wanna block the ability to scroll the window while in fullscreen and hide the window scrollbars

@OscarGodson
Copy link
Owner Author

Making progress:

Firefox:
firefox fullscreen

It's pretty buggy right now unfortunately. There's still some kinks I wanna work out before pushing anything to our 0.1.0 branch, but in case anyone is following this, it's getting close.

@dadambickford
Copy link
Collaborator

Looking good! I was just testing out that new pull request from @jwmcpeak and wanted to make sure you were aware of whats goin on with the fullscreen in safari. It's supported but has a big wonky white bar in the center, and wouldn't let me input any text.

@OscarGodson
Copy link
Owner Author

@dadambickford yep, it's on the list, see: #6

I had assigned it to you awhile ago since I figure it's more of a CSS issue in the JS where I setup all the styles for fullscreen. The 0.1.0 branch has fullscreen working now (but you can't close fullscreen yet! Have to refresh) if you wanna take a stab at getting it to work right go ahead. It's assigned to you so I wont touch it unless you assign it back to me.

@OscarGodson
Copy link
Owner Author

Working in FF and Chrome now. IE9 is the last one and we can finally close this sucker!

@OscarGodson
Copy link
Owner Author

Well, this was strange. EpicEditor is working great out of the box in IE9 now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants