-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fullscreen in non-supported browsers #32
Comments
This now doesn't only include IE, but Firefox too see #22 which means this is being bumped to the public alpha milestone |
Also we'll wanna see if we can trigger IE's fullscreen programmaticall. Users can access fullscreen via F11, so if possible we'd do the same thing we'd do for other browsers like Firefox by making the Also, we'll wanna block the ability to scroll the window while in fullscreen and hide the window scrollbars |
Looking good! I was just testing out that new pull request from @jwmcpeak and wanted to make sure you were aware of whats goin on with the fullscreen in safari. It's supported but has a big wonky white bar in the center, and wouldn't let me input any text. |
@dadambickford yep, it's on the list, see: #6 I had assigned it to you awhile ago since I figure it's more of a CSS issue in the JS where I setup all the styles for fullscreen. The 0.1.0 branch has fullscreen working now (but you can't close fullscreen yet! Have to refresh) if you wanna take a stab at getting it to work right go ahead. It's assigned to you so I wont touch it unless you assign it back to me. |
Working in FF and Chrome now. IE9 is the last one and we can finally close this sucker! |
Well, this was strange. EpicEditor is working great out of the box in IE9 now. |
While not entirely important, it'd be great to still support fullscreen by doing "fullwindow" rather true fullscreen. i.e. the editor would fill the window and act just as if it would in fullscreen in supported browsers.
The text was updated successfully, but these errors were encountered: